FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(django-google-spanner): support Django 6.0 by sakthivelmanii · Pull Request #18128 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

feat(django-google-spanner): support Django 6.0 - #18128

Open
sakthivelmanii wants to merge 2 commits into
mainfrom
add-django-6.0-support
ConversationCommits (2)ChecksFiles changed
Open

feat(django-google-spanner): support Django 6.0#18128
sakthivelmanii wants to merge 2 commits into
mainfrom
add-django-6.0-support

Conversation

sakthivelmanii commented Aug 17, 2026 •
edited by parthea
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #18053 🦕

gemini-code-assist Bot reviewed Aug 17, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces support for Django 6.0, including dependency updates, tuple-casting for lookup parameters, an asynchronous autocommit setter, and a Spanner-specific JSON path compiler. The review feedback highlights critical improvements: resolving syntax, type, and SQL injection issues in compile_json_path by utilizing json.dumps; wrapping the async autocommit operation in self.execute_wrapper to align with Django standards; and fixing invalid shell syntax and compatibility issues in the new test suite script.

Comment thread packages/django-google-spanner/django_spanner/operations.py Outdated
Comment thread packages/django-google-spanner/django_spanner/base.py Outdated
Comment thread packages/django-google-spanner/django_test_suite_6.0.sh Outdated
parthea reviewed Aug 18, 2026
View reviewed changes
Comment thread packages/django-google-spanner/setup.py Outdated
sakthivelmanii force-pushed the add-django-6.0-support branch 4 times, most recently from 311d5d1 to cfa5943 Compare August 19, 2026 13:39
sakthivelmanii marked this pull request as ready for review August 19, 2026 13:39
sakthivelmanii requested review from a team as code owners August 19, 2026 13:40

parthea commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

/gemini review

gemini-code-assist Bot reviewed Aug 19, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces support for Django 6.0 in the django-google-spanner package. Key changes include updating supported versions and dependencies, implementing async autocommit handling, adding Django 6.0 test exclusions, and updating database features, operations, and schema editors to support index inclusion columns and returning columns from inserts. Feedback on these changes highlights two important issues: first, the _index_include_sql helper in schema.py should resolve actual database column names via model._meta.get_field(field).column rather than using str(field) directly; second, the async autocommit wrapper in base.py should use thread_sensitive=True with sync_to_async to ensure thread safety and prevent connection sharing issues.

Comment thread packages/django-google-spanner/django_spanner/schema.py
Comment thread packages/django-google-spanner/django_spanner/base.py Outdated
sakthivelmanii force-pushed the add-django-6.0-support branch from cfa5943 to b219da1 Compare August 19, 2026 16:05
parthea reviewed Aug 19, 2026
View reviewed changes
Comment thread packages/django-google-spanner/django_spanner/operations.py Outdated
Comment thread packages/django-google-spanner/django_spanner/lookups.py Outdated
parthea requested changes Aug 19, 2026
View reviewed changes
Comment thread packages/django-google-spanner/setup.py
"sqlparse >= 0.3.0",
"google-cloud-spanner >= 3.13.0",
"django >= 5.2, < 6.0",
"google-cloud-spanner >= 3.69.1",

parthea Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please can you clarify if we really need to bump google-cloud-spanner? Do tests fail with 3.13.0?

Is there a lower minimum that we can set here?

If 3.69.1 is yanked or has a regression, users may not be able to install/use the latest version of django-google-spanner
https://pypi.org/project/google-cloud-spanner/3.69.1/

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

parthea parthea requested changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

sakthivelmanii

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(django-spanner): support Django 6.0

2 participants

Back | FazBrowse Home | New Git URL