FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(storage): add run_benchmark_tests.sh for automated time-based GC… by shradhakatyal · Pull Request #18138 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

feat(storage): add run_benchmark_tests.sh for automated time-based GC… - #18138

Draft
shradhakatyal wants to merge 5 commits into
mainfrom
add-gcs-read-benchmark-runner
ConversationCommits (5)ChecksFiles changed
Draft

feat(storage): add run_benchmark_tests.sh for automated time-based GC…#18138
shradhakatyal wants to merge 5 commits into
mainfrom
add-gcs-read-benchmark-runner

Conversation

shradhakatyal commented Aug 18, 2026

Copy link
Copy Markdown
  • Adds run_benchmark_tests.sh under packages/google-cloud-storage/cloudbuild/ to automate high-bandwidth GCS read microbenchmarks for large objects (10 GiB file sizes).
  • Dynamically updates config.yaml to test multi-process worker pools (PROCESSES=48) across standard REST and BidiReadObject DirectPath gRPC (zonal buckets).
  • Automatically verifies and pre-seeds required GCS test objects prior to benchmark execution to ensure consistent benchmark conditions.
  • Emits structured JSON metrics via --benchmark-json for automated ingestion into Cloud Build CI

gemini-code-assist Bot reviewed Aug 18, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces an automated Google Cloud Storage read microbenchmark runner script (run_benchmark_tests.sh) designed for GitHub CI/CD and high-bandwidth GCE VMs. The review feedback identifies two critical areas for improvement: first, a race condition and a NameError in the Python pre-seeding block where concurrent processes attempt to write to the same payload file and reference an undefined variable; second, a style guide violation where the configuration loaded from config.yaml is not type-validated before indexing.

Comment thread packages/google-cloud-storage/cloudbuild/run_benchmark_tests.sh
Comment thread packages/google-cloud-storage/cloudbuild/run_benchmark_tests.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL