| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
This pull request updates the test database lifecycle management for sqlalchemy-spanner. It extends the stale database cleanup threshold from 10 to 30 minutes, introduces session-isolated database IDs, and records database session metadata to track and report active duration upon teardown. The review comments point out critical issues: truncating the Unix timestamp to 9 digits changes the year to 1992, which would cause immediate deletion of newly created databases; the cleanup routine needs to handle both 10-digit and 13-digit timestamps; and the loaded JSON metadata should be type-validated as a dictionary before lookup to comply with the repository's style guide.
Sorry, something went wrong.
…d validate metadata dict type
… garbage collection
…nerous 1-hour cutoff
…prevent cross-session drops
…nt cross-session database drops
… fallback to sqlite
…o avoid NameError
…h underscores instead of hyphens
…NER_CONFIG instead of falling back to sqlite
…ral_execute TypeError
…panner without literal_execute
…ine argument to create and drop database scripts
…st session as well
| Back | FazBrowse Home | New Git URL |
Problem
When running comprehensive compliance and system test suites for sqlalchemy-spanner, test sessions occasionally encountered "404 Database not found" errors. This happened because:
Solution
Notes for Reviewers