chore: Add thread safety to overcome race condition during 401 client certificate rotation in transports - #18168
Open
agrawalradhika-cell wants to merge 8 commits into
Open
chore: Add thread safety to overcome race condition during 401 client certificate rotation in transports#18168agrawalradhika-cell wants to merge 8 commits into
agrawalradhika-cell wants to merge 8 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Introduce a lock for thread-safe reauthentication when mTLS parameters change.
Added a reauthentication lock to prevent concurrent reconfiguration of mTLS channel when client certificate changes.
Added a test to ensure reauthentication lock is acquired on unauthorized response for MTLS sessions.
Added a test to verify reauthentication lock acquisition on unauthorized responses in AuthorizedHttp.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces thread safety during mutual TLS (mTLS) re-authentication in both the requests and urllib3 transport adapters by utilizing a threading lock. This prevents race conditions when checking and reconfiguring the mTLS channel upon receiving an unauthorized response. Unit tests have been added to verify that the lock is correctly acquired. The review feedback points out redundant duplicate imports of the http.client module in both test files, which should be cleaned up.
Sorry, something went wrong.
Comment thread
packages/google-auth/tests/transport/test_requests.py
Outdated
Comment thread
packages/google-auth/tests/transport/test_urllib3.py
Outdated
Updated the request URL in the test case to be more general.
Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: Add thread safety to overcome race condition during 401 client certificate rotation in transports
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #17756 🦕