feat(google/maps/mapmanagement/v2): onboard a new library - #18173
Draft
quirogas wants to merge 1 commit into
Draft
feat(google/maps/mapmanagement/v2): onboard a new library#18173quirogas wants to merge 1 commit into
quirogas wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the google-maps-mapmanagement package, adding the generated Python client library for the Google Maps Map Management v2 API. This includes sync and async clients, transports, types, documentation, generated samples, and release configuration updates. The review feedback suggests sorting the __all__ lists alphabetically in both the main package and types initialization files to improve code readability and maintainability.
Sorry, something went wrong.
Comment on lines
+149
to
+176
| __all__ = ( | ||
| "MapManagementAsyncClient", | ||
| "CreateMapConfigRequest", | ||
| "CreateMapContextConfigRequest", | ||
| "CreateStyleConfigRequest", | ||
| "DeleteMapConfigRequest", | ||
| "DeleteMapContextConfigRequest", | ||
| "DeleteStyleConfigRequest", | ||
| "GetMapConfigRequest", | ||
| "GetMapContextConfigRequest", | ||
| "GetStyleConfigRequest", | ||
| "ListMapConfigsRequest", | ||
| "ListMapConfigsResponse", | ||
| "ListMapContextConfigsRequest", | ||
| "ListMapContextConfigsResponse", | ||
| "ListStyleConfigsRequest", | ||
| "ListStyleConfigsResponse", | ||
| "MapConfig", | ||
| "MapContextConfig", | ||
| "MapFeatures", | ||
| "MapManagementClient", | ||
| "MapRenderingType", | ||
| "StyleConfig", | ||
| "StyleConfigView", | ||
| "UpdateMapConfigRequest", | ||
| "UpdateMapContextConfigRequest", | ||
| "UpdateStyleConfigRequest", | ||
| ) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The __all__ list in a Python module should be alphabetically sorted to improve readability and maintainability.
__all__ = (
"CreateMapConfigRequest",
"CreateMapContextConfigRequest",
"CreateStyleConfigRequest",
"DeleteMapConfigRequest",
"DeleteMapContextConfigRequest",
"DeleteStyleConfigRequest",
"GetMapConfigRequest",
"GetMapContextConfigRequest",
"GetStyleConfigRequest",
"ListMapConfigsRequest",
"ListMapConfigsResponse",
"ListMapContextConfigsRequest",
"ListMapContextConfigsResponse",
"ListStyleConfigsRequest",
"ListStyleConfigsResponse",
"MapConfig",
"MapContextConfig",
"MapFeatures",
"MapManagementAsyncClient",
"MapManagementClient",
"MapRenderingType",
"StyleConfig",
"StyleConfigView",
"UpdateMapConfigRequest",
"UpdateMapContextConfigRequest",
"UpdateStyleConfigRequest",
)- The __all__ list in a Python module should be alphabetically sorted to improve readability and maintainability.
Sorry, something went wrong.
Comment on lines
+43
to
+68
| __all__ = ( | ||
| "CreateMapConfigRequest", | ||
| "CreateMapContextConfigRequest", | ||
| "CreateStyleConfigRequest", | ||
| "DeleteMapConfigRequest", | ||
| "DeleteMapContextConfigRequest", | ||
| "DeleteStyleConfigRequest", | ||
| "GetMapConfigRequest", | ||
| "GetMapContextConfigRequest", | ||
| "GetStyleConfigRequest", | ||
| "ListMapConfigsRequest", | ||
| "ListMapConfigsResponse", | ||
| "ListMapContextConfigsRequest", | ||
| "ListMapContextConfigsResponse", | ||
| "ListStyleConfigsRequest", | ||
| "ListStyleConfigsResponse", | ||
| "MapConfig", | ||
| "MapContextConfig", | ||
| "MapFeatures", | ||
| "StyleConfig", | ||
| "UpdateMapConfigRequest", | ||
| "UpdateMapContextConfigRequest", | ||
| "UpdateStyleConfigRequest", | ||
| "MapRenderingType", | ||
| "StyleConfigView", | ||
| ) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
To improve maintainability, please keep the __all__ list sorted alphabetically.
__all__ = (
"CreateMapConfigRequest",
"CreateMapContextConfigRequest",
"CreateStyleConfigRequest",
"DeleteMapConfigRequest",
"DeleteMapContextConfigRequest",
"DeleteStyleConfigRequest",
"GetMapConfigRequest",
"GetMapContextConfigRequest",
"GetStyleConfigRequest",
"ListMapConfigsRequest",
"ListMapConfigsResponse",
"ListMapContextConfigsRequest",
"ListMapContextConfigsResponse",
"ListStyleConfigsRequest",
"ListStyleConfigsResponse",
"MapConfig",
"MapContextConfig",
"MapFeatures",
"MapRenderingType",
"StyleConfig",
"StyleConfigView",
"UpdateMapConfigRequest",
"UpdateMapContextConfigRequest",
"UpdateStyleConfigRequest",
)- The __all__ list in a Python module should be alphabetically sorted to improve readability and maintainability.
Sorry, something went wrong.
quirogas
marked this pull request as draft
August 19, 2026 21:14
parthea
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 963642371
Fixes b/545715827