Factor API-related calls into service-specific helpers. - #1820
Merged
tseaver merged 4 commits intoMay 25, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
gcloud/logging/client.py
| def logging_api(self): | ||
| """Helper for logging-related API calls.""" | ||
| if self._logging_api is None: | ||
| self._logging_api = _LoggingAPI(self.connection) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
It's a lot to digest, but nothing glaring. Anything in particular I should focus on? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
This one is a pretty mechanical transform, following the earlier pubsub pattern. Given CI testing for coverage and lint, he "usual suspects" would be copy-pasta errors, particularly docstrings, |
Sorry, something went wrong.
Addresses: #1820 (comment)
Comment thread
gcloud/logging/client.py
Outdated
|
|
||
| @property | ||
| def metrics_api(self): | ||
| """Helper for logging-related API calls.""" |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
Did a docs pass and made a few comments. Everything (save for those few comments) LGTM. |
Sorry, something went wrong.
Add links to relevant REST API docs. Addresses: #1820 (comment)
Merged
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: omair <omairn@google.com>
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
* fix: Read scopes from ADC json for impersoanted cred * secret * secret update * secret update * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
🤖 I have created a release *beep* *boop* --- ## [2.42.0](googleapis/google-auth-library-python@v2.41.1...v2.42.0) (2025-10-24) ### Features * Add trust boundary support for external accounts. ([#1809](googleapis/google-auth-library-python#1809)) ([36ecb1d](googleapis/google-auth-library-python@36ecb1d)) ### Bug Fixes * Read scopes from ADC json for impersoanted cred ([#1820](googleapis/google-auth-library-python#1820)) ([62c0fc8](googleapis/google-auth-library-python@62c0fc8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Mar 6, 2026
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
…interactive display of the results (#1820) * add anywidget as extra python package * Add anywidget to bigframes * add the first testcase * fix mypy error * Show first page of results (to_pandas_batches()) is done * add the testcase * Add more testcase * change a import * change anywidget mode for plain text * fix noxfile * add anywidget for docx * ignore missing import * fix doctest * add unittest * add notebook test * fix unit-10.12 * change testcase * make anywidget addtional * remove anywidget_mode.ipynb in notebook session due to deferred mode * fix typo * fix failed testcase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modeled on the pubsub changes in #1700 and #1736.