Add customer-supplied encryption to storage - #1844
Merged
daspecster merged 3 commits intoJun 15, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
daspecster
force-pushed
the
customer-supplied-encryption
branch
from
0d91e0b to
f713c3e
Compare
June 7, 2016 19:53
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Comment thread
gcloud/storage/blob.py
Outdated
| """ | ||
| return bucket_path + '/o/' + quote(blob_name, safe='') | ||
|
|
||
| @staticmethod |
This comment was marked as spam.
daspecster
force-pushed
the
customer-supplied-encryption
branch
2 times, most recently
from
737bf7e to
bfaf049
Compare
June 8, 2016 20:04
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Comment thread
gcloud/_helpers.py
|
|
||
| :type value: bytes | ||
| :param value: bytes value to attempt string conversion on. | ||
| """ |
This comment was marked as spam.
daspecster
force-pushed
the
customer-supplied-encryption
branch
from
b4152a2 to
824bf93
Compare
June 10, 2016 11:27
Copy link
Copy Markdown
Contributor
Author
|
@dhermes I squashed the commits for this. Let me know if you have any other feedback. |
Sorry, something went wrong.
Comment thread
gcloud/_helpers.py
Outdated
| raise TypeError('%r could not be converted to bytes' % (value,)) | ||
|
|
||
|
|
||
| def _from_bytes(value): |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possible solution to resolve #1841.
I think my tests could use some feedback.