FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update references to gcloud by daspecster · Pull Request #1845 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Update references to gcloud - #1845

Closed
daspecster wants to merge 1 commit into
googleapis:masterfrom
daspecster:change-usage-of-gcloud
ConversationCommits (1)ChecksFiles changed
Closed

Update references to gcloud#1845
daspecster wants to merge 1 commit into
googleapis:masterfrom
daspecster:change-usage-of-gcloud

Conversation

daspecster commented Jun 7, 2016

Copy link
Copy Markdown
Contributor

Updates for https://github.com/GoogleCloudPlatform/gcloud-common/issues/142.

Changing references to gcloud-python from gcloud if referring to the python library.

daspecster added the docs label Jun 7, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 7, 2016
dhermes reviewed Jun 8, 2016
View reviewed changes
Comment thread docs/conf.py Outdated
# -*- coding: utf-8 -*-
#
# gcloud documentation build configuration file, created by
# gcloud-python documentation build configuration file, created by

This comment was marked as spam.

Sign in to view

dhermes commented Jun 8, 2016

Copy link
Copy Markdown
Contributor

@daspecster I don't see any of these changes as being necessary / helpful.

@jgeewax Is this what you had in mind?

daspecster force-pushed the change-usage-of-gcloud branch from 15747de to 2d0dd58 Compare June 8, 2016 14:20

daspecster commented Jun 8, 2016

Copy link
Copy Markdown
Contributor Author

I think the main changes that were mentioned in the issue were in index.rst.

dhermes commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

@daspecster There is only one change in index.rst and that change obscures the fact that the user will pip install the PyPI package gcloud (not gcloud-python)

daspecster commented Jun 9, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@dhermes, yeah...should we just close this then?

dhermes commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

That is my preference

daspecster commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

We can reopen if @jgeewax knows of something we missed.

daspecster closed this Jun 9, 2016
daspecster deleted the change-usage-of-gcloud branch June 9, 2016 18:46
daspecster restored the change-usage-of-gcloud branch June 24, 2016 17:28

daspecster commented Jun 24, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Reopening per @jgeewax https://github.com/GoogleCloudPlatform/gcloud-common/issues/142#issuecomment-228390438

/cc @dhermes

daspecster reopened this Jun 24, 2016

daspecster commented Jun 27, 2016

Copy link
Copy Markdown
Contributor Author

Ping @dhermes
/cc @tseaver

dhermes commented Jun 29, 2016

Copy link
Copy Markdown
Contributor

@jgeewax said "Yes we need that change.". What is "that change"?

daspecster commented Jun 29, 2016

Copy link
Copy Markdown
Contributor Author

Yeah, I'm not entirely sure TBH.

jgeewax commented Jul 4, 2016

Copy link
Copy Markdown
Contributor

I meant we should re-open, and then double check all the other items in the issue body (https://github.com/GoogleCloudPlatform/gcloud-common/issues/142).

The big obvious one is the glaring "gcloud" on https://googlecloudplatform.github.io/gcloud-python/

daspecster commented Jul 4, 2016

Copy link
Copy Markdown
Contributor Author

I updated the homepage. Should we change or leave the other updates?

daspecster force-pushed the change-usage-of-gcloud branch from 7361e6b to 73f23c0 Compare July 14, 2016 19:48

daspecster commented Jul 26, 2016

Copy link
Copy Markdown
Contributor Author

Closed by #2026.

daspecster closed this Jul 26, 2016
daspecster deleted the change-usage-of-gcloud branch January 24, 2017 15:18
parthea pushed a commit that referenced this pull request Oct 21, 2023
[Asset] Test: fix bucket clean up logic. [(#1845)](GoogleCloudPlatfor…
33a852c 
…m/python-docs-samples#1845)
parthea pushed a commit that referenced this pull request Apr 1, 2026
chore(main): release 2.9.0 (#1845)
2ef7c90 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL