Adjust anchor scroll in docs to show actual line. - #1900
Merged
daspecster merged 1 commit intoJun 27, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
parthea
added a commit
that referenced
this pull request
Mar 2, 2026
[A recent change](googleapis/google-auth-library-python@36ecb1d#diff-4762e5cf4088fa77af8bf63829f842548a4cad6e76be593786876e314807cd8f) added an internal _refresh_token method to some credentials files. Parts of the codebase were already using `_refresh_token` as an internal variable, holding a token value This causes some inconsistencies in the codebase, where it's not always clear if `_refresh_token` is referring to an action or an object It was also causing complications in internal code that depended on _refresh_token objects This PR renames the methods to `_perform_refresh_token`, to avoid the duplicate naming --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
…ady finished (#1900) fix: retry query job after ambiguous failures Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fixed header isn't accounted for when scrolling to anchor points so the original anchor text is obscured.
I would actually prefer to remove the fixed header instead of merging this PR. If it's ok to remove the fixed header let me know and I can do that instead!