FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Drop 'Table.rename'. by tseaver · Pull Request #1908 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Drop 'Table.rename'. - #1908

Merged
tseaver merged 2 commits into
googleapis:bigtable-v2from
tseaver:bigtable-v2-drop_table_rename
Jun 26, 2016
ConversationCommits (2)ChecksFiles changed
Merged

Drop 'Table.rename'.#1908
tseaver merged 2 commits into
googleapis:bigtable-v2from
tseaver:bigtable-v2-drop_table_rename

Conversation

tseaver commented Jun 26, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

It was never actually implemented on the back-end in V1, and has been dropped altogether in V2.

Drop 'Table.rename'.
9a2d313 
It was never actually implemented on the back-end in V1, and has been
dropped altogether in V2.
tseaver added the api: bigtable Issues related to the Bigtable API. label Jun 26, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2016
tseaver mentioned this pull request Jun 26, 2016
Closed

daspecster commented Jun 26, 2016

Copy link
Copy Markdown
Contributor

@tseaver looks like there is more to remove for this in the system-test and protos.

https://github.com/GoogleCloudPlatform/gcloud-python/search?utf8=%E2%9C%93&q=rename

tseaver commented Jun 26, 2016

Copy link
Copy Markdown
Contributor Author

@daspecster Thanks forthe catch! OK to merge now?

daspecster commented Jun 26, 2016

Copy link
Copy Markdown
Contributor

There's some in the proto as well. But if we don't care about that since it's generated then LGTM!

tseaver commented Jun 26, 2016

Copy link
Copy Markdown
Contributor Author

@daspecster

There's some in the proto as well. But if we don't care about that since it's generated then LGTM!

Yup, the _generated/ subdir is based on the Bigtable V1 protos, which contained that method, even though the backend always returned a NOT_IMPLEMENTED error. The V2 proto-generated code is added in #1903, and doesn't have the method.

Eventually (see #1384), we'd like to get rid of both those directories and rely on googleapis-generated PyPI releases for datastore and bigtable proto-generated code.

tseaver merged commit 35103f9 into googleapis:bigtable-v2 Jun 26, 2016
tseaver deleted the bigtable-v2-drop_table_rename branch June 26, 2016 20:33
This was referenced Jun 28, 2016
Closed
Merged
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(main): release 1.13.1 (#1908)
df2a075 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL