Fix GAX logging system tests - #1952
Merged
tseaver merged 6 commits intoJul 6, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Use integer for HTTP status code (the gRPC version cares).
Comment thread
system_tests/logging_.py
|
|
||
|
|
||
| def _retry_backoff(result_predicate, meth, *args, **kw): | ||
| from grpc.beta.interfaces import StatusCode |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
@daspecster I added the missing continue in 6ffe88d. Any remaining issues? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM! |
Sorry, something went wrong.
This was referenced Aug 3, 2016
Closed
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
* feat: support load job option ColumnNameCharacterMap * add unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging system tests now pass both with GCLOUD_ENABLE_GAX and without it.
The _retry_backoff function added in 3a3613e may help toward #1619.