FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix pubsub context manager exit error by daspecster · Pull Request #1956 · googleapis/google-cloud-python · GitHub

Fix pubsub context manager exit error - #1956

Merged
daspecster merged 2 commits into
googleapis:masterfrom
daspecster:fix-pupsub-exit-context-no-commits
Jul 4, 2016
Merged

Fix pubsub context manager exit error#1956
daspecster merged 2 commits into
googleapis:masterfrom
daspecster:fix-pupsub-exit-context-no-commits

Conversation

Copy link
Copy Markdown
Contributor

Possible fix for #1955, checking the length of self.messages before __exit__.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 4, 2016

tseaver commented Jul 4, 2016

Copy link
Copy Markdown
Contributor

@daspecster I think a more comprehensive fix would be to check self.messages inside Batch.commit, and exit early. We do document the imperative Batch API, which would still be broken otherwise.

tseaver commented Jul 4, 2016

Copy link
Copy Markdown
Contributor

LGTM

daspecster merged commit eddc4e0 into googleapis:master Jul 4, 2016
daspecster deleted the fix-pupsub-exit-context-no-commits branch July 4, 2016 17:48
This was referenced Aug 3, 2016
parthea pushed a commit that referenced this pull request Mar 2, 2026
…#1956)

This PR introduces the google.auth.aio.transport.mtls module, providing
asynchronous helper methods for mTLS certificate discovery
[go/caa:x509-async-support](http://goto.google.com/caa:x509-async-support).
These helpers are designed to be for x.509 certs discovery and
non-blocking, ensuring that disk I/O operations are async during mTLS
handshake process. Plus, added unit tests respectively for the helper
functions.

Please note: Only x.509 creds are in scope of this project currently.
Context aware or ECP credentials are not in scope of this project
currently.

Next Steps: Will create a followup PR will that will utilize these
helpers to implement `configure_mtls_channel` within the
`AsyncAuthorizedSession` class.

---------

Signed-off-by: Radhika Agrawal <agrawalradhika@google.com>
codyoss pushed a commit that referenced this pull request Mar 5, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.0.0-20260216162532-e323d455c92b
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c
<details><summary>google-auth: v2.49.0</summary>

##
[v2.49.0](google-auth-v2.48.0...google-auth-v2.49.0)
(2026-03-05)

### Features

* Add helper methods for asynchronous x.509 certificate discovery
(#1956)
([3368f27](3368f27c))

* Support timeout as aiohttp.ClientTimeout and total_attempts (max
retries) in AsyncAuthorizedSession (#1961)
([4d818b9](4d818b93))

* mTLS configuration via x.509 for asynchronous session in google-auth
(#1959)
([7b70fea](7b70fead))

* support an alternative env to decide if mtls should be enabled (#1945)
([89fc6f2](89fc6f2e))

### Bug Fixes

* gracefully fallback if workload fields are missing from cert config
(#16022)
([3ed2d68](3ed2d680))

</details>


<details><summary>google-cloud-alloydb: v0.8.0</summary>

##
[v0.8.0](google-cloud-alloydb-v0.7.0...google-cloud-alloydb-v0.8.0)
(2026-03-05)

### Features

* Add a new field to support Dataplex integration configuration
(PiperOrigin-RevId: 878006289)
([6120fb0](6120fb0d))

* Add a new field to support Dataplex integration configuration
(PiperOrigin-RevId: 878006289)
([6120fb0](6120fb0d))

</details>


<details><summary>google-cloud-compute: v1.45.0</summary>

##
[v1.45.0](google-cloud-compute-v1.44.0...google-cloud-compute-v1.45.0)
(2026-03-05)

### Features

* Update Compute Engine v1 API to revision 20260213 The breaking change
exemption is approved in internal http://b/488396206
([22601c7](22601c79))

</details>


<details><summary>google-cloud-compute-v1beta: v0.8.0</summary>

##
[v0.8.0](google-cloud-compute-v1beta-v0.7.0...google-cloud-compute-v1beta-v0.8.0)
(2026-03-05)

### Features

* Update Compute Engine v1beta API to revision 20260213
([4049c9b](4049c9b6))

</details>


<details><summary>google-cloud-documentai: v3.11.0</summary>

##
[v3.11.0](google-cloud-documentai-v3.10.0...google-cloud-documentai-v3.11.0)
(2026-03-05)

### Features

* Added a field for enabling image and table annotation for layout
parser processor (PiperOrigin-RevId: 877500954)
([6120fb0](6120fb0d))

* Added a field for enabling image and table annotation for layout
parser processor (PiperOrigin-RevId: 877500954)
([6120fb0](6120fb0d))

</details>


<details><summary>google-cloud-firestore: v2.24.0</summary>

##
[v2.24.0](google-cloud-firestore-v2.23.0...google-cloud-firestore-v2.24.0)
(2026-03-05)

### Features

* use cryptographically secure random for new document ids (#1162)
([3619a31](3619a31e))

* expose the variable definition in the Cloud Firestore API
(PiperOrigin-RevId: 877535984)
([4937235](4937235e))

* Expose the `Index.unique` parameter (PiperOrigin-RevId: 865444806)
([5a17963](5a17963a))

* Expose the `Database.mongodb_compatible_data_access_mode` parameter
(PiperOrigin-RevId: 865444806)
([5a17963](5a17963a))

* Expose the `Database.firestore_data_access_mode` parameter
(PiperOrigin-RevId: 865444806)
([5a17963](5a17963a))

* Expose the `Database.realtime_updates_mode` parameter
(PiperOrigin-RevId: 865444806)
([5a17963](5a17963a))

### Bug Fixes

* improve pipeline create_from (#1158)
([d771742](d7717421))

### Documentation

* Update documentation on several parameters, especially when relating
to the new `enterprise` database edition (PiperOrigin-RevId: 865444806)
([5a17963](5a17963a))

</details>


<details><summary>google-cloud-hypercomputecluster: v0.3.0</summary>

##
[v0.3.0](google-cloud-hypercomputecluster-v0.2.0...google-cloud-hypercomputecluster-v0.3.0)
(2026-03-05)

### Features

* onboard a new library (PiperOrigin-RevId: 873108574)
([6876f64](6876f64b))

</details>


<details><summary>google-cloud-logging: v3.14.0</summary>

##
[v3.14.0](google-cloud-logging-v3.13.0...google-cloud-logging-v3.14.0)
(2026-03-05)

### Features

* support mTLS certificates when available (#1071)
([c73e439](c73e4390))

</details>


<details><summary>google-cloud-network-management: v1.33.0</summary>

##
[v1.33.0](google-cloud-network-management-v1.32.0...google-cloud-network-management-v1.33.0)
(2026-03-05)

### Features

* Add API fields related to GKE Pods and Network Policies
(PiperOrigin-RevId: 875021492)
([6120fb0](6120fb0d))

* Add API fields related to GKE Pods and Network Policies
(PiperOrigin-RevId: 875021492)
([6120fb0](6120fb0d))

</details>


<details><summary>google-cloud-storagebatchoperations: v0.5.0</summary>

##
[v0.5.0](google-cloud-storagebatchoperations-v0.4.0...google-cloud-storagebatchoperations-v0.5.0)
(2026-03-05)

### Features

* add new transformation `update_object_custom_context`
(PiperOrigin-RevId: 875324745)
([6120fb0](6120fb0d))

* add new transformation `update_object_custom_context`
(PiperOrigin-RevId: 875324745)
([6120fb0](6120fb0d))

</details>


<details><summary>google-cloud-vectorsearch: v0.6.0</summary>

##
[v0.6.0](google-cloud-vectorsearch-v0.5.0...google-cloud-vectorsearch-v0.6.0)
(2026-03-05)

### Features

* Added index and search configuration management (PiperOrigin-RevId:
876429709)
([6120fb0](6120fb0d))

* Added index and search configuration management (PiperOrigin-RevId:
876429709)
([6120fb0](6120fb0d))

### Bug Fixes

* Removed obsolete field `vertex` from message
`.google.cloud.vectorsearch.v1.Ranker` (PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

* Removed obsolete field `vertex` from message
`.google.cloud.vectorsearch.v1.Ranker` (PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

* Removed obsolete message `VertexRanker` (PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

* Removed obsolete message `VertexRanker` (PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

### Documentation

* Updated documentation for Index Creation, Import Data Objects, Search
(PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

* Updated documentation for Index Creation, Import Data Objects, Search
(PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

</details>


<details><summary>googleapis-common-protos: v1.73.0</summary>

##
[v1.73.0](googleapis-common-protos-v1.72.0...googleapis-common-protos-v1.73.0)
(2026-03-05)

### Features

* Add a new field to support Dataplex integration configuration
(PiperOrigin-RevId: 878006289)
([6120fb0](6120fb0d))

* Add API fields related to GKE Pods and Network Policies
(PiperOrigin-RevId: 875021492)
([6120fb0](6120fb0d))

* Add API fields related to GKE Pods and Network Policies
(PiperOrigin-RevId: 875021492)
([6120fb0](6120fb0d))

* Update Compute Engine v1beta API to revision 20260213
([6120fb0](6120fb0d))

* A new field `right_child_digest_hex` is added to message
`.google.cloud.universalledger.v1.ProofOfInclusion`, which replaces
`right_child_hash_hex` (PiperOrigin-RevId: 875734641)
([6120fb0](6120fb0d))

* A new field `inference_generation_config` is added to message
`.google.cloud.aiplatform.v1beta1.EvaluationConfig` (PiperOrigin-RevId:
875384529)
([6120fb0](6120fb0d))

* Added a field for enabling image and table annotation for layout
parser processor (PiperOrigin-RevId: 877500954)
([6120fb0](6120fb0d))

* Added a field for enabling image and table annotation for layout
parser processor (PiperOrigin-RevId: 877500954)
([6120fb0](6120fb0d))

* A new field `evaluation_run` is added to message
`.google.cloud.aiplatform.v1beta1.EvaluateDatasetRun`
(PiperOrigin-RevId: 875384529)
([6120fb0](6120fb0d))

* add AskContexts and AsyncRetrieveContexts APIs to VertexRagService
(PiperOrigin-RevId: 877654221)
([6120fb0](6120fb0d))

* Added index and search configuration management (PiperOrigin-RevId:
876429709)
([6120fb0](6120fb0d))

* add v1beta networkconnectivity libraries (PiperOrigin-RevId:
876282040)
([6120fb0](6120fb0d))

* A new field `left_child_digest_hex` is added to message
`.google.cloud.universalledger.v1.ProofOfInclusion`, which replaces
`left_child_hash_hex` (PiperOrigin-RevId: 875734641)
([6120fb0](6120fb0d))

* Update Compute Engine v1 API to revision 20260213 The breaking change
exemption is approved in internal http://b/488396206
([6120fb0](6120fb0d))

* add new transformation `update_object_custom_context`
(PiperOrigin-RevId: 875324745)
([6120fb0](6120fb0d))

* add new transformation `update_object_custom_context`
(PiperOrigin-RevId: 875324745)
([6120fb0](6120fb0d))

* Add a new field to support Dataplex integration configuration
(PiperOrigin-RevId: 878006289)
([6120fb0](6120fb0d))

* Added index and search configuration management (PiperOrigin-RevId:
876429709)
([6120fb0](6120fb0d))

* A new field `root_digest_hex` is added to message
`.google.cloud.universalledger.v1.MerkleTree`, which replaces
`root_hash_hex` (PiperOrigin-RevId: 875734641)
([6120fb0](6120fb0d))

### Bug Fixes

* Removed obsolete message `VertexRanker` (PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

* Removed obsolete field `vertex` from message
`.google.cloud.vectorsearch.v1.Ranker` (PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

* Removed obsolete message `VertexRanker` (PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

* Update existing packaging option
`cloud.google.com/go/auditmanager/apiv1/auditmanagerpb;auditmanagerpb`
for `go_package` (PiperOrigin-RevId: 875794180)
([6120fb0](6120fb0d))

* Removed obsolete field `vertex` from message
`.google.cloud.vectorsearch.v1.Ranker` (PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

### Documentation

* comment on `evaluate_dataset_response` clarified (PiperOrigin-RevId:
875384529)
([6120fb0](6120fb0d))

* move deprecation notices on deprecated fields earlier in the field
description (PiperOrigin-RevId: 875734641)
([6120fb0](6120fb0d))

* indicated where fields (notably account and contract comments) are
considered public information (PiperOrigin-RevId: 875734641)
([6120fb0](6120fb0d))

* Updated documentation for Index Creation, Import Data Objects, Search
(PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

* Updated documentation for Index Creation, Import Data Objects, Search
(PiperOrigin-RevId: 876429709)
([6120fb0](6120fb0d))

* general grammar corrections (PiperOrigin-RevId: 875734641)
([6120fb0](6120fb0d))

</details>
parthea pushed a commit that referenced this pull request Mar 6, 2026
…set (#1956)

* fix: do not overwrite page_size with max_results when start_index is set

* update test
parthea pushed a commit that referenced this pull request Apr 1, 2026
#1956)

* fix: add warnings for duplicated or conflicting type hints in bigframes function

* only warm conflict

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL