Fixed a majority of pep8 errors in gcloud. by kleyow · Pull Request #200 · googleapis/google-cloud-python · GitHub

No description provided.

I should run pep8 with 2 indents, i.e. pep8 --ignore=E111 gcloud/connection.py?

$ pep8 --ignore=E111 gcloud/datastore/demo/__init__.py 
gcloud/datastore/demo/__init__.py:8:80: E501 line too long (92 > 79 characters)
$ pep8 --ignore=E111 gcloud/datastore/entity.py 
gcloud/datastore/entity.py:46:80: E501 line too long (86 > 79 characters)
gcloud/datastore/entity.py:51:80: E501 line too long (83 > 79 characters)
gcloud/datastore/entity.py:58:80: E501 line too long (84 > 79 characters)
gcloud/datastore/entity.py:71:80: E501 line too long (82 > 79 characters)
gcloud/datastore/entity.py:119:80: E501 line too long (88 > 79 characters)
gcloud/datastore/entity.py:124:80: E501 line too long (85 > 79 characters)
gcloud/datastore/entity.py:138:80: E501 line too long (101 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/acl.py 
gcloud/storage/acl.py:382:80: E501 line too long (81 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/bucket.py 
gcloud/storage/bucket.py:105:80: E501 line too long (81 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/connection.py 
gcloud/storage/connection.py:467:80: E501 line too long (80 > 79 characters)
gcloud/storage/connection.py:479:80: E501 line too long (93 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/demo/__init__.py 
gcloud/storage/demo/__init__.py:8:80: E501 line too long (92 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/iterator.py 
gcloud/storage/iterator.py:149:80: E501 line too long (91 > 79 characters)
gcloud/storage/iterator.py:177:80: E501 line too long (85 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/key.py 
gcloud/storage/key.py:98:80: E501 line too long (81 > 79 characters)
gcloud/storage/key.py:211:9: E123 closing bracket does not match indentation of opening bracket's line
gcloud/storage/key.py:235:11: E123 closing bracket does not match indentation of opening bracket's line
$ pep8 --ignore=E111 gcloud/storage/test_bucket.py 
gcloud/storage/test_bucket.py:353:80: E501 line too long (80 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/test_connection.py 
gcloud/storage/test_connection.py:158:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:173:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:189:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:209:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:226:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:276:44: E241 multiple spaces after ':'
gcloud/storage/test_connection.py:296:44: E241 multiple spaces after ':'

To fix the indents, I have been testing out a combination of pep8ify and my own solution for indenting doscstrings (which pep8ify, pyfmt and other auto-format libraries fail on).

I am happy to continue that effort after this commit gets checked in.

We also want to pass pylint, as that checks code style in addition to syntax. We can discuss that more in #179

I ran git ls-files gcloud*py and there were 13 Python files, not included in this commit.

Nine of them check out just fine:

gcloud/__init__.py
gcloud/credentials.py
gcloud/datastore/demo/__main__.py
gcloud/datastore/demo/demo.py
gcloud/datastore/helpers.py
gcloud/datastore/transaction.py
gcloud/demo.py
gcloud/storage/exceptions.py
gcloud/storage/test_exceptions.py

However, the following errors were detected:

$ pep8 --ignore=E111 gcloud/datastore/connection.py
gcloud/datastore/connection.py:76:9: E123 closing bracket does not match indentation of opening bracket's line
gcloud/datastore/connection.py:159:80: E501 line too long (81 > 79 characters)
gcloud/datastore/connection.py:229:80: E501 line too long (88 > 79 characters)
$ pep8 --ignore=E111 gcloud/datastore/query.py
gcloud/datastore/query.py:50:7: E123 closing bracket does not match indentation of opening bracket's line
gcloud/datastore/query.py:66:80: E501 line too long (93 > 79 characters)
$ pep8 --ignore=E111 gcloud/storage/demo/__init__.py
gcloud/storage/demo/__init__.py:8:80: E501 line too long (92 > 79 characters)

In addition, the file gcloud/datastore/datastore_v1_pb2.py is all kinds of messed up, but I presume we should leave it as-is. We should consider using a .gitattributes file to check it in as binary and also in #178 we should ignore this file in a programmatic PEP/pylint check.

@dhermes definitely leave the generated 'datastore_v1_pb2.py' as-is.

We need to debate / document the style guide (by reference / delta to whatever authoritative specs we choose), and then automate testing of them (e.g., via something like 'tox -e lint', including automating exceptions).

RE: automation, I checked out this branch and tested every .py file with pep8 --ignore=E111. If @kleyow likes, we can do the whitespace fixes here too, or I'm happy to do it with pep8ify and my custom docstring indent script.

In addition to passing pep8 <file> I'd like to have our files pass pylint --reports=n without any warnings or errors.

@dhermes Go ahead and do it with your script. Yep sounds good.

@kleyow Since you've already done a bulk of the work, let's check this in and then I can tackle the rest with the automated tools.

You can ignore the two files left out: gcloud/storage/demo/__init__.py and gcloud/datastore/connection.py but can you try to resolve the issues in existing files?

@tseaver Does this sound good?

Whoops misclicked, issues were fixed in kleyow@b8a989f

Should I switch to

 headers = {
         'Content-Type': 'application/x-protobuf',
         'Content-Length': str(len(data)),
     }

in this ticket.

Yes please do. Also run pep8 --ignore=E111 on each of the files to make sure they have no issues.

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

#200) * chore: use gapic-generator-python 0.62.1 fix: restore 100% coverage for generated clients feat: adds REST server-streaming support fix: add special method parameters to set of reserved module names feat: expose extended operations annotations within generator fix: resolve DuplicateCredentialArgs error when using credentials_file committer: parthea PiperOrigin-RevId: 425964861 Source-Link: googleapis/googleapis@84b1a5a Source-Link: googleapis/googleapis-gen@4fb761b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.7.2](https://www.github.com/googleapis/python-secret-manager/compare/v2.7.1...v2.7.2) (2021-09-24) ### Bug Fixes * add 'dict' annotation type to 'request' ([b5e0c81](https://www.github.com/googleapis/python-secret-manager/commit/b5e0c818eeca22cae59406693f435595d2b92f8d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: https://togithub.com/googleapis/synthtool/commit/0ddbff8012e47cde4462fe3f9feab01fbc4cdfd6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b

Source-Link: googleapis/synthtool@694118b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ec49167c606648a063d1222220b48119c912562849a0528f35bfb592a9f72737 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@56da63e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@facee4c Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:9743664022bd63a8084be67f144898314c7ca12f0a03e422ac17c733c129d803 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@571ee2c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:660abdf857d3ab9aabcd967c163c70e657fcc5653595c709263af5f3fa23ef67

Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:58c7342b0bccf85028100adaa3d856cb4a871c22ca9c01960d996e66c40548ce

Source-Link: googleapis/synthtool@ca87909 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore(deps): update dependency google-cloud-storage to v2.1.0 * add pin for google-cloud-storage for py3.6 Co-authored-by: Anthonios Partheniou <partheniou@google.com>

….0 (#200)

) Source-Link: https://togithub.com/googleapis/synthtool/commit/0c7b0333f44b2b7075447f43a121a12d15a7b76a Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547

- [ ] Regenerate this pull request now. docs: list oneofs in docstring fix(deps): require google-api-core >= 1.28.0 fix(deps): drop packaging dependency committer: busunkim96@ PiperOrigin-RevId: 406468269 Source-Link: googleapis/googleapis@83d81b0 Source-Link: googleapis/googleapis-gen@2ff001f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmZmMDAxZmJhY2I5ZTc3ZTcxZDczNGRlNWY5NTVjMDVmZGFlODUyNiJ9

adding label example when writing a timeseries in python Remaking this due to the commit lint failure in #200 and it being easier to just make a new PR. Closing #200. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [✔️] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-monitoring/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [✔️ for linter, unable to run the nox tests because of issues unrelated] Ensure the tests and linter pass - [✔️] Code coverage does not decrease (if any source code was changed) - [✔️, no doc updates required ] Appropriate docs were updated (if necessary) Fixes #200 🦕

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [backoff](https://togithub.com/litl/backoff) | `==1.11.0` -> `==1.11.1` | [![age](https://badges.renovateapi.com/packages/pypi/backoff/1.11.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/backoff/1.11.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/backoff/1.11.1/compatibility-slim/1.11.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/backoff/1.11.1/confidence-slim/1.11.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>litl/backoff</summary> ### [`v1.11.1`](https://togithub.com/litl/backoff/blob/master/CHANGELOG.md#v1111-2021-07-14) [Compare Source](https://togithub.com/litl/backoff/compare/v1.11.0...v1.11.1) ##### Changed - Update **version** in backoff module </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-translate).

…versions (#200) Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10566.

* chore: Update gapic-generator-python to v1.8.2 PiperOrigin-RevId: 504289125 Source-Link: googleapis/googleapis@38a48a4 Source-Link: googleapis/googleapis-gen@b2dc226 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJkYzIyNjYzZGJlNDdhOTcyYzhkOGMyZjhhNGRmMDEzZGFmZGNiYyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [3.7.1](https://www.github.com/googleapis/python-cloudbuild/compare/v3.7.0...v3.7.1) (2021-11-05) ### Bug Fixes * **deps:** require google-api-core >= 1.28.0, drop packaging dep ([f3fb436](https://www.github.com/googleapis/python-cloudbuild/commit/f3fb4367ba598506d4cdd296870b61a8ffad75ef)) ### Documentation * list oneofs in docstring ([f3fb436](https://www.github.com/googleapis/python-cloudbuild/commit/f3fb4367ba598506d4cdd296870b61a8ffad75ef)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

dhermes mentioned this pull request Sep 28, 2014

Make sure code is PEP8 compliant #179

Closed

dhermes reviewed Sep 28, 2014
View reviewed changes

Comment thread gcloud/datastore/__init__.py

This comment was marked as spam.

Sign in to view

kleyow force-pushed the pe8_pyflakes branch from 3f3d0f1 to b8a989f Compare September 28, 2014 19:33

dhermes mentioned this pull request Sep 29, 2014

Make datastore.entity PEP8 and pylint compliant #189

Merged

tseaver reviewed Sep 29, 2014
View reviewed changes

Comment thread gcloud/datastore/connection.py Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

dhermes added in progress labels Sep 29, 2014

kleyow closed this Sep 29, 2014

beriberikix removed the in progress label Sep 29, 2014

kleyow reopened this Sep 29, 2014

kleyow force-pushed the pe8_pyflakes branch 3 times, most recently from 5efa5f1 to f4fc666 Compare September 30, 2014 22:29

Kevin Leyow added 3 commits September 30, 2014 17:59

Fixed a majority of pep8 errors in gcloud.

a23ffdc

Fixed long lines and some more pep8 errors.

d20be07

Reverted summary lines and changed closing brackets for addibility.

76e360c

kleyow force-pushed the pe8_pyflakes branch from f4fc666 to cd0843f Compare September 30, 2014 23:19

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency pytest to v7.1.0 (#200 )

174a01b

parthea added a commit that referenced this pull request Jun 4, 2023

docs: fix changelog header to consistent size (#200 )

9d1bb3a

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea added a commit that referenced this pull request Jun 4, 2023

docs: fix changelog header to consistent size (#200 )

85ac60d

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Jul 6, 2023

chore: fail samples nox session if python version is missing (#200 )

7bbb39f

parthea added a commit that referenced this pull request Sep 22, 2023

chore: update .repo-metadata.json (#200 )

4289deb

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore: new owl bot post processor docker image (#200 )

634e9b7

Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:58c7342b0bccf85028100adaa3d856cb4a871c22ca9c01960d996e66c40548ce

parthea added a commit that referenced this pull request Sep 22, 2023

chore: update .repo-metadata.json (#200 )

617afd9

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(python): Add kokoro configs for python 3.10 samples testing (#200 )

58e4666

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-storage to v1.42.0 (#200 )

45e95f4

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 1.5.2 (#200 )

9674416

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-asset to v3 (#200 )

96362a5

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-containeranalysis to v2.6…

9e05095

….0 (#200)

parthea pushed a commit that referenced this pull request Oct 21, 2023

fix(deps): pin 'google-{api,cloud}-core', 'google-auth' to allow 2.x …

13b6110

…versions (#200) Expand pins on library dependencies in preparation for these dependencies taking a new major version. See #10566.

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pytest to v7.1.0 (#200 )

0eca550

Fixed a majority of pep8 errors in gcloud. by kleyow · Pull Request #200 · googleapis/google-cloud-python · GitHub

Uh oh!

Fixed a majority of pep8 errors in gcloud. - #200

Fixed a majority of pep8 errors in gcloud.#200silvolu merged 6 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom kleyow:pe8_pyflakeskleyow/gcloud-python:pe8_pyflakesCopy head branch name to clipboard

Conversation

kleyow commented Sep 28, 2014

Uh oh!

dhermes commented Sep 28, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Sep 28, 2014

Uh oh!

dhermes commented Sep 28, 2014

Uh oh!

dhermes commented Sep 28, 2014

Uh oh!

tseaver commented Sep 29, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Sep 29, 2014

Uh oh!

dhermes commented Sep 29, 2014

Uh oh!

kleyow commented Sep 29, 2014

Uh oh!

dhermes commented Sep 29, 2014

Uh oh!

kleyow commented Sep 29, 2014

Uh oh!

kleyow commented Sep 29, 2014

Uh oh!

dhermes commented Sep 29, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Fixed a majority of pep8 errors in gcloud.#200
silvolu merged 6 commits into
googleapis:masterfrom
kleyow:pe8_pyflakes