Fix doc line linking - #2025
Merged
daspecster merged 6 commits intoJul 29, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
scripts/generate_json_docs.py
| source_path = source.replace(path, '') | ||
|
|
||
| return source_path[1:] | ||
| return source_path |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver there we go. LMKWYT! |
Sorry, something went wrong.
Comment thread
scripts/generate_json_docs.py
| ABSOLUTE_LIBRARY_PATH = '/'.join(os.path.abspath(gcloud.__file__) | ||
| .split('/')[:-2]) | ||
|
|
||
|
|
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
daspecster
force-pushed
the
fix-doc-line-linking
branch
from
3055ed3 to
6bbe052
Compare
July 26, 2016 17:30
Comment thread
scripts/generate_json_docs.py
Outdated
| if 'gcloud-python' in source: | ||
| source_path = source.split('gcloud-python')[1] | ||
| if ABSOLUTE_LIBRARY_PATH in source: | ||
| source_path = source.replace(ABSOLUTE_LIBRARY_PATH, '') |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
The test fix is my bad: I introduced the test failure while merging / fixing up #2029. I restarted Travis after pushing my fix. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
This was referenced Aug 3, 2016
Closed
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2024 and adds Error Reporting module.