Add pyflakes to 'tox -e lint'. by tseaver · Pull Request #229 · googleapis/google-cloud-python · GitHub

No description provided.

I like the idea but see this a temporary measure. pyflakes isn't nearly opinionated enough.

Also, this will complain a lot about the autogenerated pb file if you don't ignore it.

@dhermes pflakes doesn't complain at all about the file on my setup:

$ git status
# On branch add_pyflakes
nothing to commit (working directory clean)
$ tox -e lint
GLOB sdist-make: /home/tseaver/projects/agendaless/Google/src/gcloud-python/setup.py
lint inst-nodeps: /home/tseaver/projects/agendaless/Google/src/gcloud-python/.tox/dist/gcloud-0.02.2.zip
lint runtests: PYTHONHASHSEED='2322207745'
lint runtests: commands[0] | pep8
directory .
checking ./setup.py
directory ./gcloud.egg-info
directory ./gcloud
checking ./gcloud/__init__.py
checking ./gcloud/connection.py
checking ./gcloud/credentials.py
checking ./gcloud/demo.py
checking ./gcloud/test_connection.py
checking ./gcloud/test_credentials.py
directory ./gcloud/storage
checking ./gcloud/storage/__init__.py
checking ./gcloud/storage/acl.py
checking ./gcloud/storage/bucket.py
checking ./gcloud/storage/connection.py
checking ./gcloud/storage/exceptions.py
checking ./gcloud/storage/iterator.py
checking ./gcloud/storage/key.py
checking ./gcloud/storage/test___init__.py
checking ./gcloud/storage/test_acl.py
checking ./gcloud/storage/test_bucket.py
checking ./gcloud/storage/test_connection.py
checking ./gcloud/storage/test_exceptions.py
checking ./gcloud/storage/test_iterator.py
checking ./gcloud/storage/test_key.py
directory ./gcloud/storage/demo
checking ./gcloud/storage/demo/__init__.py
checking ./gcloud/storage/demo/__main__.py
checking ./gcloud/storage/demo/demo.py
directory ./gcloud/datastore
checking ./gcloud/datastore/__init__.py
checking ./gcloud/datastore/connection.py
checking ./gcloud/datastore/dataset.py
checking ./gcloud/datastore/entity.py
checking ./gcloud/datastore/helpers.py
checking ./gcloud/datastore/key.py
checking ./gcloud/datastore/query.py
checking ./gcloud/datastore/test___init__.py
checking ./gcloud/datastore/test_connection.py
checking ./gcloud/datastore/test_dataset.py
checking ./gcloud/datastore/test_entity.py
checking ./gcloud/datastore/test_helpers.py
checking ./gcloud/datastore/test_key.py
checking ./gcloud/datastore/test_query.py
checking ./gcloud/datastore/test_transaction.py
checking ./gcloud/datastore/transaction.py
directory ./gcloud/datastore/demo
checking ./gcloud/datastore/demo/__init__.py
checking ./gcloud/datastore/demo/__main__.py
checking ./gcloud/datastore/demo/demo.py
directory ./docs
directory ./docs/_components
directory ./docs/_templates
directory ./docs/_static
directory ./docs/_build
directory ./docs/_build/doctrees
directory ./docs/_build/html
directory ./docs/_build/html/_sources
directory ./docs/_build/html/_static
directory ./docs/_build/html/_images
directory ./docs/_build/html/_modules
directory ./docs/_build/html/_modules/gcloud
directory ./docs/_build/html/_modules/gcloud/storage
directory ./docs/_build/html/_modules/gcloud/datastore
directory ./docs/examples
directory ./docs/examples/expenses
directory ./docs/examples/expenses/expenses.egg-info
directory ./docs/examples/expenses/expenses
directory ./docs/examples/expenses/expenses/scripts
lint runtests: commands[1] | pyflakes gcloud
___________________________________ summary ____________________________________
lint: commands succeeded
congratulations :)

Yes I confirmed this as well.

That makes me think pyflakes is quite useless.
We should be consistent in using a blacklist as in tox.ini or a whitelist here. IMO every piece of Python code we have should be checked unless we have special reason not to. Just as in the change here, unused variables / imports in demo code or setup.py are worthy of getting rid of.

pyflakes catches semantic issues, such as:

./gcloud/storage/test_key.py:105:9: F841 local variable 'orig_key_path' is assigned to but never used

flake8 combines pyflakes with pep8.

Yes I'm aware (I ran it on HEAD as I'm assuming you did). It's just not enough style checking.

LGTM on this and we'll take the discussion elsewhere.

Usurped by #238

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* feat: Add MultisliceNode --- feat: Enable Force on DeleteQueuedResource PiperOrigin-RevId: 536935689 Source-Link: googleapis/googleapis@5649269 Source-Link: googleapis/googleapis-gen@9562345 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTU2MjM0NWEwOTU4ODc2MThiOTQ1YTVhN2I2NzFhMmFkOGE4NTM2YSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@25083af Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/26c7505b2f76981ec1707b851e1595c8c06e90fc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790

Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

* chore: update to gapic-generator-python 1.5.0 feat: add support for `google.cloud.<api>.__version__` PiperOrigin-RevId: 484665853 Source-Link: googleapis/googleapis@8eb249a Source-Link: googleapis/googleapis-gen@c8aa327 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzhhYTMyN2I1ZjQ3ODg2NWZjM2ZkOTFlM2MyNzY4ZTU0ZTI2YWQ0NCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update version in gapic_version.py * add .release-please-manifest.json with correct version * set manifest to true in .github/release-please.yml * add release-please-config.json * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: Update to gapic-generator-python 1.6.0 feat(python): Add typing to proto.Message based class attributes feat(python): Snippetgen handling of repeated enum field PiperOrigin-RevId: 487326846 Source-Link: googleapis/googleapis@da380c7 Source-Link: googleapis/googleapis-gen@61ef576 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjFlZjU3NjJlZTY3MzFhMGNiYmZlYTIyZmQwZWVjZWU1MWFiMWM4ZSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: new APIs added to reflect updates to the filestore service - Add ENTERPRISE Tier - Add snapshot APIs: RevertInstance, ListSnapshots, CreateSnapshot, DeleteSnapshot, UpdateSnapshot - Add multi-share APIs: ListShares, GetShare, CreateShare, DeleteShare, UpdateShare - Add ConnectMode to NetworkConfig (for Private Service Access support) - New status codes (SUSPENDED/SUSPENDING, REVERTING/RESUMING) - Add SuspensionReason (for KMS related suspension) - Add new fields to Instance information: max_capacity_gb, capacity_step_size_gb, max_share_count, capacity_gb, multi_share_enabled PiperOrigin-RevId: 487492758 Source-Link: googleapis/googleapis@5be5981 Source-Link: googleapis/googleapis-gen@ab0e217 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWIwZTIxN2Y1NjBjYzJjMWFmYzExNDQxYzJlYWI2YjY5NTBlZmQyYiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * update path to snippet metadata json * chore: Update gapic-generator-python to v1.6.1 PiperOrigin-RevId: 488036204 Source-Link: googleapis/googleapis@08f275f Source-Link: googleapis/googleapis-gen@555c094 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTU1YzA5NDVlNjA2NDllMzg3MzlhZTY0YmM0NTcxOWNkZjcyMTc4ZiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * use templated owlbot.py and setup.py Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@5f2a608 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>

…229) Source-Link: https://togithub.com/googleapis/synthtool/commit/b4fe62efb5114b6738ad4b13d6f654f2bf4b7cc0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3bf87e47c2173d7eed42714589dc4da2c07c3268610f1e47f8e1a30decbfc7f1

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

* fix: integrate gapic-generator-python-1.4.1 and enable more py_test targets PiperOrigin-RevId: 473833416 Source-Link: googleapis/googleapis@565a550 Source-Link: googleapis/googleapis-gen@1ee1a06 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/python-documentai/compare/v1.1.0...v1.2.0) (2021-10-14) ### Features * add support for python 3.10 ([#228](https://www.github.com/googleapis/python-documentai/issues/228)) ([86d7cd6](https://www.github.com/googleapis/python-documentai/commit/86d7cd6062d282770b0ba2252e72d5e0f90dfd95)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@56da63e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7

Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97

Source-Link: googleapis/synthtool@ca87909 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: update comments for ListVoicesRequest PiperOrigin-RevId: 417752787 Source-Link: googleapis/googleapis@3e58417 Source-Link: googleapis/googleapis-gen@e9ad9d6 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTlhZDlkNjM4NjAwNjM4YTAwYjA3MmZmYThkNDE4YTc4OThmMmQ0NiJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.9.1](https://www.github.com/googleapis/python-texttospeech/compare/v2.9.0...v2.9.1) (2022-01-08) ### Documentation * Added virtualenv comment for clarity ([#225](https://www.github.com/googleapis/python-texttospeech/issues/225)) ([61a7fce](https://www.github.com/googleapis/python-texttospeech/commit/61a7fcec0611712cdb1692b830db4aaca4d411b0)) * update comments for ListVoicesRequest ([#229](https://www.github.com/googleapis/python-texttospeech/issues/229)) ([9ea340c](https://www.github.com/googleapis/python-texttospeech/commit/9ea340cee20298630a6a15bed0ed2df9f69b3d13)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

- [ ] Regenerate this pull request now. chore: fix docstring for first attribute of protos committer: @busunkim96 PiperOrigin-RevId: 401271153 Source-Link: googleapis/googleapis@787f8c9 Source-Link: googleapis/googleapis-gen@81decff Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODFkZWNmZmU5ZmM3MjM5NmE4MTUzZTc1NmQxZDY3YTZlZWNmZDYyMCJ9

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

* chore: add aap-dpes to codeowners Removing cicd and adding aap-dpes * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…le (#229) Source-Link: googleapis/synthtool@a7ed11e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6e7328583be8edd3ba8f35311c76a1ecbc823010279ccb6ab46b7a76e25eafcc Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@facee4c Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:9743664022bd63a8084be67f144898314c7ca12f0a03e422ac17c733c129d803 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-storage](https://togithub.com/googleapis/python-storage) | `==1.42.0` -> `==1.42.1` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.42.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.42.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.42.1/compatibility-slim/1.42.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-storage/1.42.1/confidence-slim/1.42.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-storage</summary> ### [`v1.42.1`](https://togithub.com/googleapis/python-storage/blob/master/CHANGELOG.md#1421-httpswwwgithubcomgoogleapispython-storagecomparev1420v1421-2021-09-07) [Compare Source](https://togithub.com/googleapis/python-storage/compare/v1.42.0...v1.42.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-vision).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9

* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0

Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7

Source-Link: googleapis/synthtool@febaccc Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:caffe0a9277daeccc4d1de5c9b55ebba0901b57c2f713ec9c876b0d4ec064f61 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@59171c8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2ed982f884312e4883e01b5ab8af8b6935f0216a5a2d82928d273081fc3be562 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Fix for #229 and #230 Manual tests show the expected license is generated in the client library files.

Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: google-cloud-policy-bot[bot] <80869356+google-cloud-policy-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@52e4e46 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:6186535cbdbf6b9fe61f00294929221d060634dae4a0795c1cefdbc995b2d605

Source-Link: googleapis/synthtool@5f2a608 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Wrap twice, once to retry 503 errors on initial API call, and again to retry the whole dance if a 503 is raised during iteration of the results. Closes #228.

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@d52e638 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…229) Source-Link: googleapis/synthtool@280ddae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:346ab2efb51649c5dde7756cbbdc60dd394852ba83b9bbffc292a63549f33c17 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Add pyflakes to 'tox -e lint'.

1018321

beriberikix added the in progress label Oct 8, 2014

tseaver added the hygiene label Oct 8, 2014

Unused variable. pyflakes is now happy.

cb2ef12

Merge remote-tracking branch 'upstream/master' into add_pyflakes

3984c4a

tseaver removed the in progress label Oct 13, 2014

tseaver closed this Oct 13, 2014

tseaver deleted the add_pyflakes branch November 6, 2014 22:43

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.7.2 (#229 )

c7e97b8

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.9.0 (#229 )

8105697

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Jun 4, 2023

chore(deps): update dependency google-auth to v2.11.0 (#229 )

92cac6d

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore: make samples 3.6 check optional (#229 )

76e2033

parthea added a commit that referenced this pull request Oct 21, 2023

chore(main): release 0.8.2 (#229 )

3e3fe78

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pytest to v7.0.1 (#229 )

de3175f

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(main): release 1.8.1 (#229 )

08db4e5

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea added a commit that referenced this pull request Oct 22, 2023

fix(deps): require protobuf <4.0.0dev (#229 )

35de9e9

parthea added a commit that referenced this pull request Oct 31, 2023

fix(deps): allow protobuf 3.19.5 (#229 )

bbec84f

* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0

parthea pushed a commit that referenced this pull request Sep 18, 2025

Release 0.7.0 (#229 )

bfeca69

parthea pushed a commit that referenced this pull request Nov 24, 2025

Add a license to the generated gapic and samples (#231 )

de2cf9e

Fix for #229 and #230 Manual tests show the expected license is generated in the client library files.

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: add SECURITY.md (#229 )

79664e4

Co-authored-by: google-cloud-policy-bot[bot] <80869356+google-cloud-policy-bot[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Nov 24, 2025

tests: harden tests of 'Query.fetch' against 503 (#229 )

a459743

Wrap twice, once to retry 503 errors on initial API call, and again to retry the whole dance if a 503 is raised during iteration of the results. Closes #228.

Add pyflakes to 'tox -e lint'. by tseaver · Pull Request #229 · googleapis/google-cloud-python · GitHub

Uh oh!

Add pyflakes to 'tox -e lint'. - #229

Add pyflakes to 'tox -e lint'.#229
tseaver wants to merge 3 commits into
googleapis:masterfrom
tseaver:add_pyflakes

tseaver commented Oct 8, 2014

Uh oh!

dhermes commented Oct 8, 2014

Uh oh!

tseaver commented Oct 8, 2014

Uh oh!

dhermes commented Oct 9, 2014

Uh oh!

tseaver commented Oct 9, 2014

Uh oh!

dhermes commented Oct 9, 2014

Uh oh!

tseaver commented Oct 13, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add pyflakes to 'tox -e lint'. by tseaver · Pull Request #229 · googleapis/google-cloud-python · GitHub

Uh oh!

Add pyflakes to 'tox -e lint'. - #229

Add pyflakes to 'tox -e lint'.#229tseaver wants to merge 3 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom tseaver:add_pyflakesCopy head branch name to clipboard

Conversation

tseaver commented Oct 8, 2014

Uh oh!

dhermes commented Oct 8, 2014

Uh oh!

tseaver commented Oct 8, 2014

Uh oh!

dhermes commented Oct 9, 2014

Uh oh!

tseaver commented Oct 9, 2014

Uh oh!

dhermes commented Oct 9, 2014

Uh oh!

tseaver commented Oct 13, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add pyflakes to 'tox -e lint'.#229
tseaver wants to merge 3 commits into
googleapis:masterfrom
tseaver:add_pyflakes