Basic implementation of Speech API. - #2344
Merged
dhermes merged 8 commits intoSep 21, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tseaver
suggested changes
Sep 18, 2016
tseaver
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thank you very much for the patch -- it is very well done!
Sorry, something went wrong.
Comment thread
docs/index.rst
Outdated
| bucket = client.get_bucket('<your-bucket-name>') | ||
| blob = bucket.blob('my-test-file.txt') | ||
| blob.upload_from_string('this is test content!') | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
Comment thread
docs/speech-usage.rst
Outdated
|
|
||
| At this moment we only support one method of the Speech API: | ||
|
|
||
| - `syncrecognize`_ |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
docs/speech-usage.rst
Outdated
|
|
||
| - `syncrecognize`_ | ||
|
|
||
| Synchronous Recognize |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
docs/speech-usage.rst
Outdated
| --------------------- | ||
|
|
||
| The :meth:`~google.cloud.speech.Client.syncrecognize` method | ||
| does speech to text on a file and returns the text |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
docs/speech-usage.rst
Outdated
|
|
||
| The :meth:`~google.cloud.speech.Client.syncrecognize` method | ||
| does speech to text on a file and returns the text | ||
| as a :class:`list` of tuples dicts (each containing a transcript an a confidence value). |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
google/cloud/speech/client.py
Outdated
| for param_name, param in required_params: | ||
| if param is None: | ||
| message = '%r cannot be None' % (param_name) | ||
| raise ValueError(message) |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
google/cloud/speech/client.py
Outdated
| if param is None: | ||
| message = '%r cannot be None' % (param_name) | ||
| raise ValueError(message) | ||
| config = dict(required_params) |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
google/cloud/speech/client.py
Outdated
| ('maxAlternatives', max_alternatives), | ||
| ('profanityFilter', profanity_filter)]: | ||
| if param is not None: | ||
| config[param_name] = param |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
unit_tests/speech/test_client.py
Outdated
| sample_rate, | ||
| max_alternatives=2, | ||
| speech_context=hints) | ||
| self.assertEqual(speechrecognition_result[0]["transcript"], 'hello') |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
unit_tests/speech/test_client.py
Outdated
| with self.assertRaises(ValueError): | ||
| client.syncrecognize(None, None, None, None) | ||
| with self.assertRaises(ValueError): | ||
| client.syncrecognize(None, "uri", None, None) |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
Thank you for your feedback! I have implemented your suggestions, except for the additional examples with extra arguments in the docs. I will try to finish this tomorrow. |
Sorry, something went wrong.
tseaver
reviewed
Sep 18, 2016
Comment thread
google/cloud/speech/client.py
| supported, which must be specified in the following | ||
| format: gs://bucket_name/object_name | ||
| :type content: bytes | ||
| :param content: Byte stream of audio. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
daspecster
reviewed
Sep 19, 2016
daspecster
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Awesome! Thank you!
Sorry, something went wrong.
Comment thread
google/cloud/speech/client.py
Outdated
| """Client to bundle configuration needed for API requests. | ||
|
|
||
| :type project: str | ||
| :param project: the project which the client acts on behalf of. Will be |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
google/cloud/speech/client.py
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Basic client for Google Cloud Speech API.""" |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
dhermes
suggested changes
Sep 19, 2016
Comment thread
docs/index.rst
| bucket = client.get_bucket('<your-bucket-name>') | ||
| blob = bucket.blob('my-test-file.txt') | ||
| blob.upload_from_string('this is test content!') | ||
| blob.upload_from_string('this is test content!') No newline at end of file |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
docs/speech-usage.rst
| .. code-block:: python | ||
|
|
||
| >>> alternatives = client.sync_recognize(None,"gs://my-bucket/recording.flac", | ||
| ... "FLAC", 16000, max_alternatives=2): |
This comment was marked as spam.
Comment thread
docs/speech-usage.rst
| >>> for alternative in alternatives: | ||
| ... print('=' * 20) | ||
| ... print(' transcript: %s' % (alternative["transcript"],)) | ||
| ... print(' confidence: %s' % (alternative["confidence"],)) |
This comment was marked as spam.
Comment thread
docs/speech-usage.rst
| ... print(' confidence: %s' % (alternative["confidence"],)) | ||
| ==================== | ||
| transcript: Hello, this is a test | ||
| confidence: 0.81 |
This comment was marked as spam.
Comment thread
google/cloud/speech/__init__.py
Outdated
|
|
||
| """Google Cloud Speech API wrapper.""" | ||
|
|
||
| from google.cloud.speech.client import Client, Encoding |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
unit_tests/speech/test_client.py
Outdated
| response = client.sync_recognize(_AUDIO_CONTENT, | ||
| encoding, | ||
| self.SAMPLE_RATE, | ||
| language_code="EN", |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
unit_tests/speech/test_client.py
Outdated
|
|
||
| self.assertEqual(REQUEST, | ||
| client.connection._requested[0]['data']) | ||
| self.assertEqual(response[0]["transcript"], 'hello') |
This comment was marked as spam.
Comment thread
unit_tests/speech/test_client.py
| }, | ||
| "audio": { | ||
| "content": _B64_AUDIO_CONTENT | ||
| } |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
unit_tests/speech/test_client.py
Outdated
|
|
||
| self.assertEqual(REQUEST, | ||
| client.connection._requested[0]['data']) | ||
| self.assertEqual(response[0]["transcript"], 'hello') |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
unit_tests/speech/test_client.py
Outdated
|
|
||
| class _Credentials(object): | ||
|
|
||
| _scopes = ('https://www.googleapis.com/auth/cloud-platform') |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
@Fematich Really great work! Especially impressed that you have Travis 100% green on your first try! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I have updated the code (included source_uri again and updated formatting/unit_tests). |
Sorry, something went wrong.
dhermes
reviewed
Sep 20, 2016
Comment thread
google/cloud/speech/client.py
|
|
||
| :type source_uri: str | ||
| :param source_uri: URI that points to a file that contains audio | ||
| data bytes as specified in RecognitionConfig. |
This comment was marked as spam.
dhermes
reviewed
Sep 21, 2016
Comment thread
google/cloud/speech/client.py
| between 0 and 1. | ||
| """ | ||
|
|
||
| if (content is None) and (source_uri is None): |
This comment was marked as spam.
dhermes
reviewed
Sep 21, 2016
Comment thread
google/cloud/speech/client.py
| raise ValueError('content and source_uri cannot be both equal to\ | ||
| None') | ||
|
|
||
| if (content is not None) and (source_uri is not None): |
This comment was marked as spam.
dhermes
reviewed
Sep 21, 2016
Comment thread
google/cloud/speech/client.py
| """ | ||
|
|
||
| if (content is None) and (source_uri is None): | ||
| raise ValueError('content and source_uri cannot be both equal to\ |
This comment was marked as spam.
dhermes
reviewed
Sep 21, 2016
Comment thread
google/cloud/speech/client.py
| None') | ||
|
|
||
| if (content is not None) and (source_uri is not None): | ||
| raise ValueError('content and source_uri cannot be both different from\ |
This comment was marked as spam.
dhermes
reviewed
Sep 21, 2016
Comment thread
google/cloud/speech/client.py
| if sample_rate is None: | ||
| raise ValueError('sample_rate cannot be None') | ||
|
|
||
| if content is not None: |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
dhermes
reviewed
Sep 21, 2016
Comment thread
unit_tests/speech/_fixtures.py
| } | ||
|
|
||
| SYNC_RECOGNIZE_EMPTY_RESPONSE = { | ||
| 'results': [] |
This comment was marked as spam.
dhermes
reviewed
Sep 21, 2016
Comment thread
unit_tests/speech/test_client.py
|
|
||
| import unittest | ||
|
|
||
| _AUDIO_SOURCE_URI = 'gs://sample-bucket/sample-recording.flac' |
This comment was marked as spam.
tseaver
approved these changes
Sep 21, 2016
dhermes
approved these changes
Sep 21, 2016
Copy link
Copy Markdown
Contributor
|
I'm going to merge as-is. I'll send a PR addressing most of my concerns. Remaining issues outside of that PR will be: |
Sorry, something went wrong.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Sep 21, 2016
Copy link
Copy Markdown
Contributor
|
@Fematich Thanks for your great work! We decided to go ahead and merge to speed up the process. We'd like to get this library feature-complete ASAP so we didn't want the review cycle to slow us down on getting the first chunks in. From here, a person working on this library full-time will take it to the finish line. You were great! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you it was a pleasure :-)! |
Sorry, something went wrong.
daspecster
added a commit
to daspecster/google-cloud-python
that referenced
this pull request
Oct 4, 2016
daspecster
added a commit
that referenced
this pull request
Oct 6, 2016
Updates from #2344 for speech API.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Updates from googleapis#2344 for speech API.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>google-cloud-bigquery: 3.39.0</summary> ## [3.39.0](googleapis/python-bigquery@v3.38.0...v3.39.0) (2025-12-12) ### Features * adds support for Python runtime 3.14 (#2322) ([6065e14c](googleapis/python-bigquery@6065e14c)) * Add ExternalRuntimeOptions to BigQuery routine (#2311) ([fa76e310](googleapis/python-bigquery@fa76e310)) ### Bug Fixes * remove ambiguous error codes from query retries (#2308) ([8bbd3d01](googleapis/python-bigquery@8bbd3d01)) * include `io.Base` in the `PathType` (#2323) ([b11e09cb](googleapis/python-bigquery@b11e09cb)) * honor custom `retry` in `job.result()` (#2302) ([e118b029](googleapis/python-bigquery@e118b029)) ### Documentation * remove experimental annotations from GA features (#2303) ([1f1f9d41](googleapis/python-bigquery@1f1f9d41)) </details> Co-authored-by: Daniel Sanche <d.sanche14@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 more reviewers5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made a basic implementation of Speech API.
This currently only supports syncrecognize from the REST-API.
I think I followed all the contribution guidelines:
However, this is my first contribution, so in case I missed something, please let me know and I will see how to fix it!