HYGIENE: Using assertIsInstance, assertIs, assertIsNone, assertIsNotNone when relevant - #2364
Merged
dhermes merged 9 commits intoSep 20, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Did this using: https://gist.github.com/dhermes/57e29d96b17a4e1543b47bd2fcebfc07 NOTE: Some usage that span multiple lines are still not changed.
Done manually by checking the output of: $ git grep ' is$' -- unit_tests/ $ git grep ' is$' -- system_tests/ $ git grep ' is ' -- unit_tests/ $ git grep ' is ' -- system_tests/
Did this using: https://gist.github.com/dhermes/f4176452c2436b14e0c97a114d98bace Also had to manually undo a few of the changes since the regex matched things like self.assertEqual(foo, [(value, has_some, parens, None)])
Copy link
Copy Markdown
Contributor
|
LGTM pending Travis. |
Sorry, something went wrong.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
This PR adds `biome.json` to enforce consistent 2-space indentation and single quotes for JavaScript and CSS files. This aligns with project style guides, automates formatting via pre-commit hooks, and prevents manual style changes from being overwritten. Currently, our Biome setup relies on default settings, which violates Google coding style guidelines. Specifically: * **Quotation Marks:** Biome's defaults do not enforce single quotes for JavaScript (as per `js_style.txt`: `screen/8NaEr3SswN6qx6D`) and CSS property values (as per `css_style.txt`: `screen/9KCh8ZVQ4ByPeDR`). * **Indentation:** Biome's defaults do not consistently enforce 2 spaces for indentation across HTML (`screen/97ZZstQc4iH4Dsb`) and JavaScript (`screen/3crxm5peLvRE2kj`) files. This configuration explicitly sets these rules to ensure full compliance. **Benefits:** * Consistent and readable JS/CSS code. * Automated style enforcement. * Reduced developer friction. **To Test:** Make a style-violating change in a `.js` or `.css` file and attempt to commit. Biome should automatically reformat it. Fixes #<issue_number_goes_here> 🦕
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677 <details><summary>bigframes: 2.33.0</summary> ## [2.33.0](google/bigframes@v2.32.0...v2.33.0) (2026-01-22) ### Features * add bigquery.ml.transform function (#2394) ([1f9ee373](google/bigframes@1f9ee373)) * Add dark mode to anywidget mode (#2365) ([2763b41d](google/bigframes@2763b41d)) * Add max_columns control for anywidget mode (#2374) ([34b5975f](google/bigframes@34b5975f)) * Configure Biome for Consistent Code Style (#2364) ([81e27b3d](google/bigframes@81e27b3d)) * Add BigQuery ObjectRef functions to `bigframes.bigquery.obj` (#2380) ([9c3bbc36](google/bigframes@9c3bbc36)) * Stabilize interactive table height to prevent notebook layout shifts (#2378) ([a634e976](google/bigframes@a634e976)) ### Bug Fixes * implement retry logic for cloud function endpoint fetching (#2369) ([0f593c27](google/bigframes@0f593c27)) * Throw if write api commit op has stream_errors (#2385) ([7abfef05](google/bigframes@7abfef05)) ### Performance Improvements * Avoid requery for some result downsample methods (#2219) ([95763ff2](google/bigframes@95763ff2)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by:
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2348/files#r79664980
Note that virtually all of these commits were created by REGEX matching / replacing scripts, so it's worth just reviewing those scripts:
I ran the unit and system tests locally to make sure they all still pass.