Modifying setup.py to separate duplicated content. - #2393
Merged
dhermes merged 1 commit intoSep 23, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dhermes
force-pushed
the
preparing-setup-for-subpackages
branch
from
6f5bf6a to
487ca1a
Compare
September 22, 2016 23:14
daspecster
reviewed
Sep 23, 2016
daspecster
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I can't seem to get this to work the way you expect?
>>> B = {'key': 'value'}
>>> c = ([], **B)
File "<stdin>", line 1
c = ([], **B)
^
SyntaxError: invalid syntax
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@daspecster the ** only works when passed to a callable (the setup() function, in this case). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Any issues with this PR? @daspecster If it didn't work, then Travis wouldn't be green 😉 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@tseaver, oh right, deep down inside I knew that. @dhermes yeah I realized that. I wasn't sure exactly how tox used setup.py or if it cared. |
Sorry, something went wrong.
daspecster
approved these changes
Sep 23, 2016
This was referenced Sep 23, 2016
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Has #2392 as diffbase.