Preserve ACL when copying or renaming blob. - #2409
Merged
daspecster merged 3 commits intoSep 28, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tseaver
suggested changes
Sep 23, 2016
Comment thread
google/cloud/storage/bucket.py
Outdated
|
|
||
| def copy_blob(self, blob, destination_bucket, new_name=None, | ||
| client=None): | ||
| client=None, preserve_acl=False): |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
google/cloud/storage/bucket.py
Outdated
| return new_blob | ||
|
|
||
| def rename_blob(self, blob, new_name, client=None): | ||
| def rename_blob(self, blob, new_name, client=None, preserve_acl=False): |
This comment was marked as spam.
This comment was marked as spam.
tseaver
reviewed
Sep 26, 2016
Comment thread
unit_tests/storage/test_bucket.py
Outdated
| self.assertEqual(new_blob.name, NEW_NAME) | ||
| self.assertIsInstance(new_blob.acl, ObjectACL) | ||
| self.assertFalse(new_blob.acl.loaded) | ||
| self.assertEqual(new_blob.acl.entities, {}) |
This comment was marked as spam.
daspecster
force-pushed
the
add-storage-preserve-acl
branch
from
8e85462 to
04ea4f7
Compare
September 27, 2016 21:54
Copy link
Copy Markdown
Contributor
Author
|
I finally circled back around. |
Sorry, something went wrong.
tseaver
approved these changes
Sep 28, 2016
tseaver
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
parthea
pushed a commit
that referenced
this pull request
Apr 1, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:1a2a85ab507aea26d787c06cc7979decb117164c81dd78a745982dfda80d4f68 <details><summary>bigframes: 2.36.0</summary> ## [2.36.0](google/bigframes@v2.35.0...v2.36.0) (2026-02-17) ### Features * Initial support for biglake iceberg tables (#2409) ([ae35a989](google/bigframes@ae35a989)) * add bigquery.ai.generate_table function (#2453) ([b925aa24](google/bigframes@b925aa24)) ### Documentation * fix generate_text and generate_table input docs (#2455) ([078bd32e](google/bigframes@078bd32e)) * update multimodal dataframe notebook to use public APIs (#2456) ([342fa723](google/bigframes@342fa723)) * use direct API for pdf chunk and pdf extract (#2452) ([543ce52c](google/bigframes@543ce52c)) * use direct API for audio transcription (#2447) ([59cbc5db](google/bigframes@59cbc5db)) * Add EXIF metadata extraction example to multimodal notebook (#2429) ([84c6f883](google/bigframes@84c6f883)) * Update multimodal notebook to use public runtime helpers (#2451) ([e36dd8b4](google/bigframes@e36dd8b4)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #2389
ACL settings are not held when copying a blob or renaming a blob.
Adds preserve_acl to Bucket.copy_blob and Bucket.rename_blob.