Moving Travis helpers out of run_pylint into shared module. - #2481
Merged
dhermes merged 2 commits intoOct 3, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is to make them more general for other tests which may want to limit the changeset. Also moving the local env. variable names into a helper script file to make them easier to access and reuse from other testing scripts.
daspecster
reviewed
Oct 3, 2016
Comment thread
scripts/script_utils.py
| # NOTE: We're a little extra cautious and make sure that the | ||
| # PR environment variable is an integer. | ||
| try: | ||
| int(os.getenv(TRAVIS_PR_ENV, '')) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
daspecster
approved these changes
Oct 3, 2016
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation to re-use these pieces in other scripts (e.g. the ones for running package-local tests)