Map gRPC errors in datastore run_query onto 'google.cloud.exceptions'. - #2496
Merged
dhermes merged 1 commit intoOct 4, 2016
Merged
Map gRPC errors in datastore run_query onto 'google.cloud.exceptions'.#2496dhermes merged 1 commit into
dhermes merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
It may be worth putting a try/except around every method and using the mapping provided in code.proto |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Yeah, this LGTM to me as a temporary fix, but I feel it'd be more thorough to do that. |
Sorry, something went wrong.
tseaver
reviewed
Oct 4, 2016
Comment thread
datastore/unit_tests/test_connection.py
|
|
||
| exc_state = _RPCState((), None, None, StatusCode.CANCELLED, None) | ||
| exc = GrpcRendezvous(exc_state, None, None, None) | ||
| self._run_query_failure_helper(exc, GrpcRendezvous) |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver Sorry merged based on @jonparrott LGTM. Happy to revert / quick fix if you have concerns |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
No worries. |
Sorry, something went wrong.
This was referenced Oct 18, 2016
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Catching gRPC error in datastore run_query and converting to our error.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Catching gRPC error in datastore run_query and converting to our error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2494.