Make 'encryption_key' an attribute of the Blob. - #2507
Merged
tseaver merged 2 commits intoOct 6, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
/cc @jonparrott, as this change might affect the snippets which demonstrate use of customer-supplied encryption keys. |
Sorry, something went wrong.
Avoids the need to plumb it through all the 'upload' and 'download' methods. Convert '_set_encryption_headers(key, headers)' into a pure function, '_get_encryption_headers(key)', returning a new dict. Preparing for use of encryption in to-be-added 'Blob.rewrite(source_blob)' method. See: #1960.
dhermes
approved these changes
Oct 6, 2016
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Still LGTM after last commit |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@dhermes While writing system tests for Blob.rewrite, I realized I needed to surface the encryption_key parameter at the Bucket.blob level, too. Unless you object, I will merge when that last, tiny change passes Travis. |
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…ryption_key_attr Make 'encryption_key' an attribute of the Blob.
chalmerlowe
pushed a commit
that referenced
this pull request
Mar 31, 2026
…rovided (#2507) Fixes b/489038951 🦕
chalmerlowe
pushed a commit
that referenced
this pull request
Mar 31, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.8.3 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c <details><summary>bigframes: v2.38.0</summary> ## [v2.38.0](google/bigframes@v2.37.0...v2.38.0) (2026-03-16) ### Features * Add `bigframes.bigquery.rand()` function (#2501) ([5c43efb7](google/bigframes@5c43efb7)) * add `df.bigquery` pandas accessor (#2513) ([91b6c245](google/bigframes@91b6c245)) * Add str, dt accessors to pd.col Expression objects (#2488) ([ce5de570](google/bigframes@ce5de570)) * add bigquery.ml.get_insights function (#2493) ([d29a6095](google/bigframes@d29a6095)) * use EUC for AI IF, CLASSIFY, and SCORE when connection is not provided (#2507) ([fe94910a](google/bigframes@fe94910a)) ### Bug Fixes * handle unsupported types and empty results in describe (#2506) ([2326ad6a](google/bigframes@2326ad6a)) * no longer automatically use anywidget in the `%%bqsql` magics (#2504) ([43353e2b](google/bigframes@43353e2b)) ### Documentation * Fix typo in ExperimentOptions class docstring (#2498) ([077cb2eb](google/bigframes@077cb2eb)) * add notebooks to user guide page (#2505) ([5cf37888](google/bigframes@5cf37888)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids the need to plumb it through all the upload_* and download_* methods.
Convert _set_encryption_headers(key, headers) into a pure function, _get_encryption_headers(key), returning a new dict.
Preparing for use of encryption in to-be-added Blob.rewrite(source_blob) method. See: #1960.