Restricting when the umbrella cover runs - #2512
Merged
dhermes merged 2 commits intoOct 6, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
isolated-cover --> cover
cover --> umbrella-cover
Also dropping `tox -e cover` from `.travis.yml` since it is
no redundant.
Copy link
Copy Markdown
Contributor
|
This looks good to me pending travis. |
Sorry, something went wrong.
daspecster
approved these changes
Oct 6, 2016
Copy link
Copy Markdown
Contributor
Author
|
Unfortunately the build still took 8 minutes because just installing the lint environment took 80s (namespace packages!) and similarly the do-nothing system test envs took 45s and 70s. Finally the docs build took 200s. Will try to get these down. I know Sphinx has support for incremental builds to it's worth taking a look. (I also know that tox disables Sphinx caching so we'd want a special hack there.) |
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Restricting when the umbrella cover runs
ohmayr
pushed a commit
that referenced
this pull request
Mar 13, 2026
chalmerlowe
pushed a commit
that referenced
this pull request
Mar 31, 2026
chalmerlowe
pushed a commit
that referenced
this pull request
Apr 1, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c <details><summary>bigframes: 2.39.0</summary> ## [2.39.0](google/bigframes@v2.38.0...v2.39.0) (2026-03-31) ### Features * add `df.bigquery.ai.forecast` method to pandas dataframe accessor (#2518) ([1126cec9](google/bigframes@1126cec9)) * support full round-trip persistence for multimodal reference cols (#2511) ([494a0a11](google/bigframes@494a0a11)) * expose DataFrame.bigquery in both pandas and bigframes DataFrames (#2533) ([69fe3176](google/bigframes@69fe3176)) ### Bug Fixes * to_gbq may swap data columns when replace table (#2532) ([17ecc65e](google/bigframes@17ecc65e)) * handle aggregate operations on empty selections (#2510) ([34fb5daa](google/bigframes@34fb5daa)) * Localize BigQuery log suppression for gbq.py (#2541) ([af49ca29](google/bigframes@af49ca29)) * Respect remote function config changes even if logic unchanged (#2512) ([b9524284](google/bigframes@b9524284)) * support melting empty DataFrames without crashing (#2509) ([e8c4603](google/bigframes@e8c46032)) ### Performance Improvements * Make executor data uploads async internally (#2529) ([96597f0b](google/bigframes@96597f0b)) ### Documentation * gemini retouch of the index page for seo (#2514) ([2e5311e2](google/bigframes@2e5311e2)) * Rename Blob column references to ObjectRef column (#2535) ([44e0ffd9](google/bigframes@44e0ffd9)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, swapping the cover envs. in the umbrella tox config:
isolated-cover --> cover cover --> umbrella-coverand dropping the (now redunant) tox -e cover from .travis.yml. Finally, wrapping the after_success: Travis call to tox -e coveralls in a check to make sure it only runs on push builds (to speed up PR builds).
NOTE: This means that Coveralls will no longer be a check on PRs.