Moving to iterators in DNS. - #2560
Merged
dhermes merged 2 commits intoOct 19, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
theacodes
approved these changes
Oct 18, 2016
Comment thread
dns/google/cloud/dns/client.py
| passed, defaults to a value set by the API. | ||
|
|
||
| :type page_token: string | ||
| :type page_token: str |
This comment was marked as spam.
Comment thread
dns/google/cloud/dns/client.py
| description=description) | ||
|
|
||
|
|
||
| def _item_to_zone(iterator, resource): |
This comment was marked as spam.
tseaver
approved these changes
Oct 18, 2016
Comment thread
dns/google/cloud/dns/zone.py
| client=client, path=path, items_key='changes', | ||
| item_to_value=_item_to_changes, | ||
| page_token=page_token, max_results=max_results) | ||
| iterator.zone = self |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
Travis failure is due to pylint: ************* Module unit_tests.test_zone R:600, 4: Too many statements (51/50) (too-many-statements) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Yup, saw that. It's from adding self.assertIs(zone, iterator.zone) and not re-running Pylint locally. D'oh! |
Sorry, something went wrong.
dhermes
force-pushed
the
dns-iterators-alt
branch
from
2f66f96 to
ea9c653
Compare
October 18, 2016 21:00
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Moving to iterators in DNS.
ohmayr
pushed a commit
that referenced
this pull request
Mar 13, 2026
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #2532 with #2558 as diffbase.