Fix #168 and #169: Rationalize 'Connection.delete_entities' by tseaver · Pull Request #257 · googleapis/google-cloud-python · GitHub

Please review this after PR #253 (it is based on that branch).

Fixes #168 and #169.

Supersedes PR #256.

Coverage remained the same when pulling 8ebace3 on tseaver:168_169-connection_delete_entities into 906700b on GoogleCloudPlatform:master.

Merged from the trunk: the earlier changesets (from PR #253) are now gone from the diff.

Can you rebase instead of merging so as not to introduce unnecessary commits into our history?

Coverage remained the same when pulling 63b08a5 on tseaver:168_169-connection_delete_entities into 83e8262 on GoogleCloudPlatform:master.

Rebasing an already-shared branch is not part of my normal workflow. After reading up here and here, I've tried the rebase as:

$ git checkout 168_169-connection_delete_entities
$ git rebase master
$ git push -f   # douche chill

Coverage remained the same when pulling 7e134d3 on tseaver:168_169-connection_delete_entities into 83e8262 on GoogleCloudPlatform:master.

Overall LGTM.

It seems strange to have delete_entities defined on Connection. That strangeness isn't dealt with here, but is worth discussing / potentially filing a follow up bug to refactor.

Fixes #169.

Fixes #168. Merges 169-connection_delete_entity, too.

Rebased to resolve merge conflicts.

WRT "strangeness": note that the connection mediates all mutations passed to the backend (saves, deletes, commits). Loading / storing / deleting entities is basically its only responsibility.

Coverage remained the same when pulling e8dda0f on tseaver:168_169-connection_delete_entities into 20ac9ef on GoogleCloudPlatform:master.

Fix #168 and #169: Rationalize 'Connection.delete_entities'

…imezone can be found.

🤖 I have created a release \*beep\* \*boop\* --- ### [2.9.1](https://www.github.com/googleapis/python-speech/compare/v2.9.0...v2.9.1) (2021-09-24) ### Bug Fixes * add 'dict' annotation type to 'request' ([e75ada8](https://www.github.com/googleapis/python-speech/commit/e75ada858d00b22fbae6d0de40771239d2f71756)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: https://togithub.com/googleapis/synthtool/commit/25083af347468dd5f90f69627420f7d452b6c50e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

* docs: Add documentation for enums fix: Add context manager return types chore: Update gapic-generator-python to v1.8.1 PiperOrigin-RevId: 503210727 Source-Link: googleapis/googleapis@a391fd1 Source-Link: googleapis/googleapis-gen@0080f83 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore: Update gapic-generator-python to v1.8.4 PiperOrigin-RevId: 507808936 Source-Link: googleapis/googleapis@64cf849 Source-Link: googleapis/googleapis-gen@53c48ca Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTNjNDhjYWMxNTNkM2IzN2YzZDJjMmRlYzQ4MzBjZmQ5MWVjNDE1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

🤖 I have created a release \*beep\* \*boop\* --- ### [3.2.3](https://www.github.com/googleapis/python-dlp/compare/v3.2.2...v3.2.3) (2021-09-24) ### Bug Fixes * add 'dict' annotation type to 'request' ([ff98215](https://www.github.com/googleapis/python-dlp/commit/ff98215e7dc3fc6a2e8b04e3b8e570cd72556f4f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

* feat: Add support for python 3.11 chore: Update gapic-generator-python to v1.8.0 PiperOrigin-RevId: 500768693 Source-Link: googleapis/googleapis@190b612 Source-Link: googleapis/googleapis-gen@7bf29a4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@d52e638 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@6252f2c Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:50e35228649c47b6ca82aa0be3ff9eb2afce51c82b66c4a03fe4afeb5ff6c0fc

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

…257) Source-Link: googleapis/synthtool@fdba3ed Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0

Source-Link: googleapis/synthtool@0ddbff8 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bced5ca77c4dda0fd2f5d845d4035fc3c5d3d6b81f245246a36aee114970082b Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…ic enums (#257) * feat: enable "rest" transport in Python for services supporting numeric enums PiperOrigin-RevId: 508143576 Source-Link: googleapis/googleapis@7a702a9 Source-Link: googleapis/googleapis-gen@6ad1279 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmFkMTI3OWMwZTdhYTc4N2FjNmI2NmM5ZmQ0YTIxMDY5MmVkZmZjZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release \*beep\* \*boop\* --- ### [2.9.1](https://www.github.com/googleapis/python-speech/compare/v2.9.0...v2.9.1) (2021-09-24) ### Bug Fixes * add 'dict' annotation type to 'request' ([e75ada8](https://www.github.com/googleapis/python-speech/commit/e75ada858d00b22fbae6d0de40771239d2f71756)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Source-Link: googleapis/synthtool@69fabae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387

Source-Link: https://togithub.com/googleapis/synthtool/commit/909573ce9da2819eeb835909c795d29aea5c724e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b

* build: fix presubmit * fix build * fix build

…licy Update/Delete API (#257) * feat: Add custom constraints CRUD APIs, proper etag support in Org Policy Update/Delete API docs: updated comments PiperOrigin-RevId: 591301652 Source-Link: googleapis/googleapis@db5ce67 Source-Link: googleapis/googleapis-gen@3c13326 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2MxMzMyNjZlZGFhZjgxYjE0YzJkZDhmZDQ3MDUxMjdkY2JjZTA2YiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* ENH: Allow partial table schema in to_gbq * CLN: applied black * BUG: make update_schema python 2.7 compatible * DOC: update docs to allow for a subset of columns in to_gbq table_schema * DOC: what's new * DOC: close parens around issue in changelog

* feat: Introduce granted scopes to credentials * adding test * check for empty granted scope * Remove 3.6 * Remove 3.6 from requirements.txt * workaround for 3.6 * exclude unittest file from owlbot

* chore(deps): update dependency google-api-core to v1.31.2 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Jim Fulton <jim@jimfulton.info>

Source-Link: googleapis/synthtool@993985f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1894490910e891a385484514b22eb5133578897eb5b3c380e6d8ad475c6647cd

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This fixes issues, generally, with the handling of repeated properties with projection queries, but also specifically for the "class" property of PolyModel entities. Fixes #248

…atetimes Fixed by 6650fae0b1cf4f5467f69dd6c7f8ab841ceaedfb. closes #257 and closes #259 refs #185 (already closed but skips weren't removed)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [importlib-metadata](https://togithub.com/python/importlib_metadata) | `==4.12.0` -> `==5.0.0` | [![age](https://badges.renovateapi.com/packages/pypi/importlib-metadata/5.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/importlib-metadata/5.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/importlib-metadata/5.0.0/compatibility-slim/4.12.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/importlib-metadata/5.0.0/confidence-slim/4.12.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>python/importlib_metadata</summary> ### [`v5.0.0`](https://togithub.com/python/importlib_metadata/blob/HEAD/CHANGES.rst#v500) [Compare Source](https://togithub.com/python/importlib_metadata/compare/v4.13.0...v5.0.0) \====== - [#97](https://togithub.com/python/importlib_metadata/issues/97), [#284](https://togithub.com/python/importlib_metadata/issues/284), [#300](https://togithub.com/python/importlib_metadata/issues/300): Removed compatibility shims for deprecated entry point interfaces. ### [`v4.13.0`](https://togithub.com/python/importlib_metadata/blob/HEAD/CHANGES.rst#v4130) [Compare Source](https://togithub.com/python/importlib_metadata/compare/v4.12.0...v4.13.0) \======= - [#396](https://togithub.com/python/importlib_metadata/issues/396): Added compatibility for `PathDistributions` originating from Python 3.8 and 3.9. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-spanner-sqlalchemy).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

tseaver mentioned this pull request Oct 17, 2014

Fix #169: remove Connection.delete_entity API #256

Closed

tseaver mentioned this pull request Oct 17, 2014

Fix #121: Drop munging of 's~' prefix onto keys. #259

Merged

dhermes reviewed Oct 19, 2014
View reviewed changes

Comment thread gcloud/datastore/connection.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 2 commits October 19, 2014 17:32

Remove 'Connection.delete_entity' API.

16738fe

Fixes #169.

Return True from 'Connection.delete_entities' unconditionally.

e8dda0f

Fixes #168. Merges 169-connection_delete_entity, too.

tseaver added a commit that referenced this pull request Oct 19, 2014

Merge pull request #257 from tseaver/168_169-connection_delete_entities

714cd5d

Fix #168 and #169: Rationalize 'Connection.delete_entities'

tseaver merged commit 714cd5d into googleapis:master Oct 19, 2014

tseaver deleted the 168_169-connection_delete_entities branch October 19, 2014 21:40

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

To fix errors such as googleapis#257 , we now default to UTC when no t…

ad061bc

…imezone can be found.

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

To fix errors such as googleapis#257 , we now default to UTC when no t…

6d29da9

…imezone can be found.

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(deps): update all dependencies (#257 )

d798590

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(python): group renovate prs (#257 )

e14cdc8

parthea added a commit that referenced this pull request Sep 22, 2023

chore(main): release 2.7.0 (#257 )

f05c38e

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.1.2 (#257 )

d619621

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore: use python-samples-reviewers (#257 )

4c1747b

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-compute to v1.2.0 (#257 )

004d3d4

parthea added a commit that referenced this pull request Oct 21, 2023

chore(main): release 2.7.3 (#257 )

d8d2491

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-vision to v2.4.3 (#257 )

444e729

parthea added a commit that referenced this pull request Dec 20, 2024

build: fix presubmit (#257 )

1bd07ed

* build: fix presubmit * fix build * fix build

parthea pushed a commit that referenced this pull request Nov 24, 2025

Add 3.8 classifier to setup.py (#257 )

6f7944a

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore: release 2.0.2 (#257 )

8ee7fcd

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Mar 6, 2026

ci: remove test skips for "Unable to infer type for parameter" date/d…

52dd927

…atetimes Fixed by 6650fae0b1cf4f5467f69dd6c7f8ab841ceaedfb. closes #257 and closes #259 refs #185 (already closed but skips weren't removed)

parthea pushed a commit that referenced this pull request Mar 9, 2026

chore: release 1.31.1 (#257 )

edbc27a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Mar 9, 2026

chore(deps): update dependency black to v22.10.0 (#257 )

3cbb1b0

Fix #168 and #169: Rationalize 'Connection.delete_entities' by tseaver · Pull Request #257 · googleapis/google-cloud-python · GitHub

Uh oh!

Fix #168 and #169: Rationalize 'Connection.delete_entities' - #257

Fix #168 and #169: Rationalize 'Connection.delete_entities'#257
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:168_169-connection_delete_entities

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

dhermes commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 19, 2014

Uh oh!

tseaver commented Oct 19, 2014

Uh oh!

tseaver commented Oct 19, 2014

Uh oh!

coveralls commented Oct 19, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix #168 and #169: Rationalize 'Connection.delete_entities' by tseaver · Pull Request #257 · googleapis/google-cloud-python · GitHub

Uh oh!

Fix #168 and #169: Rationalize 'Connection.delete_entities' - #257

Fix #168 and #169: Rationalize 'Connection.delete_entities'#257tseaver merged 2 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom tseaver:168_169-connection_delete_entitiesCopy head branch name to clipboard

Conversation

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

dhermes commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

tseaver commented Oct 17, 2014

Uh oh!

coveralls commented Oct 17, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Oct 19, 2014

Uh oh!

tseaver commented Oct 19, 2014

Uh oh!

tseaver commented Oct 19, 2014

Uh oh!

coveralls commented Oct 19, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix #168 and #169: Rationalize 'Connection.delete_entities'#257
tseaver merged 2 commits into
googleapis:masterfrom
tseaver:168_169-connection_delete_entities