Replace types string with str. - #2579
Conversation
Sorry, something went wrong.
Used the command: ag -l 'rtype: string' | xargs sed -i .bak 's/rtype: string/rtype: str/g' Based on this comment: googleapis#2485 (comment) `str` is a type, `string` is a module.
Uses command:
ag -l 'type ([^:]+): string' | \
xargs gsed -r -i.bak -e 's/type ([^:]+): string/type \1: str/g'
Note: [-r for gsed (GNU sed) is needed for group
matching](http://superuser.com/a/336819/125262).
|
😆 |
Sorry, something went wrong.
| """ID for the dataset resource. | ||
|
|
||
| :rtype: string, or ``NoneType`` | ||
| :rtype: str, or ``NoneType`` |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Uses the command:
ag -l 'type ([^:]+): boolean' | \
xargs gsed -r -i.bak -e 's/type ([^:]+): boolean/type \1: bool/g'
dhermes
left a comment
There was a problem hiding this comment.
I actually reviewed every line. Why? Because I'm crazy.
LGTM
(I think it'll be hilarious if Travis / Sphinx barfs on this.)
Sorry, something went wrong.
Uses the command:
ag -l 'rtype: boolean' | xargs sed -i .bak 's/rtype: boolean/rtype: bool/g'
|
Thanks. For reviewing. I just added some commits for boolean -> bool, too, based on #2485 (comment) |
Sorry, something went wrong.
GAH! Next time, please "heads up new code" first, then push to the PR. (Since review already finished.) Preference: send two PRs. |
Sorry, something went wrong.
|
@tswast bool stuff looks good too. Ping me (or @jonparrott) when Travis is green? |
Sorry, something went wrong.
|
Works for me. (Two PRs next time and pinging for Travis) |
Sorry, something went wrong.
Replace types string with str.
Replace types string with str.
Replace types string with str.
Replace types string with str.
Replace types string with str.
Replace types string with str.
Replace types string with str.
Replace types string with str.
Replace types string with str.
Replace types string with str.
Replace types string with str.
Replace types string with str.
Based on this comment: #2485 (comment)
For rtypes, used the command:
For types, used the command:
ag -l 'type ([^:]+): string' | \ xargs gsed -r -i.bak -e 's/type ([^:]+): string/type \1: str/g'Note: -r for gsed (GNU sed) is needed for group matching.