Use Transcript object in sync and async. - #2613
Merged
daspecster merged 1 commit intoOct 25, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
14 tasks
dhermes
reviewed
Oct 25, 2016
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Mostly LGTM, though ping me once issues resolved
Sorry, something went wrong.
Comment thread
speech/google/cloud/speech/client.py
| from google.cloud.speech.encoding import Encoding | ||
| from google.cloud.speech.operation import Operation | ||
| from google.cloud.speech.sample import Sample | ||
| from google.cloud.speech.transcript import Transcript |
This comment was marked as spam.
Comment thread
speech/google/cloud/speech/client.py
Outdated
| return api_response['results'][0]['alternatives'] | ||
| return [Transcript.from_api_repr(alternative) | ||
| for alternative | ||
| in api_response['results'][0]['alternatives']] |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
speech/google/cloud/speech/transcript.py
Outdated
| def from_api_repr(cls, transcript): | ||
| """Factory: construct ``Transcript`` from JSON response. | ||
|
|
||
| :type transcript: :class:`~SpeechRecognitionAlternative` |
This comment was marked as spam.
Comment thread
speech/google/cloud/speech/transcript.py
| :rtype: :class:`~Transcript` | ||
| :returns: Instance of ``Transcript``. | ||
| """ | ||
| return cls(transcript['transcript'], transcript['confidence']) |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
speech/unit_tests/test_client.py
| self.assertEqual(response, expected) | ||
| alternative = SYNC_RECOGNIZE_RESPONSE['results'][0]['alternatives'][0] | ||
| expected = [Transcript.from_api_repr(alternative)] | ||
| self.assertIsInstance(response[0], Transcript) |
This comment was marked as spam.
Comment thread
speech/unit_tests/test_client.py
Outdated
| expected = [Transcript.from_api_repr(alternative)] | ||
| self.assertIsInstance(response[0], Transcript) | ||
| self.assertEqual(response[0].transcript, expected[0].transcript) | ||
| self.assertEqual(response[0].confidence, expected[0].confidence) |
This comment was marked as spam.
Comment thread
speech/unit_tests/test_client.py
Outdated
| SYNC_RECOGNIZE_RESPONSE['results'][0]['alternatives'][0])] | ||
| self.assertIsInstance(response[0], Transcript) | ||
| self.assertEqual(response[0].transcript, expected[0].transcript) | ||
| self.assertEqual(response[0].confidence, expected[0].confidence) |
This comment was marked as spam.
dhermes
approved these changes
Oct 25, 2016
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM pending my two nits and length checks. Feel free to incorporate my feedback about the results[0] bit, but don't feel required to.
Sorry, something went wrong.
Comment thread
speech/unit_tests/test_client.py
Outdated
| alternative = SYNC_RECOGNIZE_RESPONSE['results'][0]['alternatives'][0] | ||
| expected = [Transcript.from_api_repr(alternative)] | ||
| expected = Transcript.from_api_repr(alternative) | ||
| self.assertEqual(len(response, 1)) |
This comment was marked as spam.
Comment thread
speech/google/cloud/speech/client.py
Outdated
| if len(api_response['results']) == 1: | ||
| results = api_response['results'] | ||
| if len(results) == 1: | ||
| result = results[0]['alternatives'] |
This comment was marked as spam.
Comment thread
speech/unit_tests/test_client.py
| expected = [Transcript.from_api_repr( | ||
| SYNC_RECOGNIZE_RESPONSE['results'][0]['alternatives'][0])] | ||
| expected = Transcript.from_api_repr( | ||
| SYNC_RECOGNIZE_RESPONSE['results'][0]['alternatives'][0]) |
This comment was marked as spam.
daspecster
force-pushed
the
add-speech-transcript
branch
from
c90f33a to
325cbe7
Compare
October 25, 2016 21:32
Copy link
Copy Markdown
Contributor
Author
|
Ok thanks! I changed the response check via your suggestion, added the length check and fixed my bug. I also just squashed the commits. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Travis is green. Merging. |
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Use Transcript object in sync and async.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
Use Transcript object in sync and async.
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
Use Transcript object in sync and async.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…les#2613) * automl: add base samples * automl: add base set of samples * Clean up tests * License year 2020, drop python2 print statement unicode * use centralized automl testing project * Fix GCS path typo * Use fake dataset for batch predict * lint: line length * fix fixture naming and use * Fix fixture changes * Catch resource exhausted error * use fake data for import test * update how to access an operation id Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
Use Transcript object in sync and async.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the spirit of smaller PRs. I started switching sync to GAPIC again and I realized that this is required first.