FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Speech GAPIC for sync_recognize. by daspecster · Pull Request #2615 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Add Speech GAPIC for sync_recognize. - #2615

Merged
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:add-speech-sync-gapic
Oct 26, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Add Speech GAPIC for sync_recognize.#2615
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:add-speech-sync-gapic

Conversation

daspecster commented Oct 25, 2016

Copy link
Copy Markdown
Contributor

This adds GAPIC support to speech sync_recognize().

daspecster added the api: speech Issues related to the Speech-to-Text API. label Oct 25, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2016
daspecster mentioned this pull request Oct 25, 2016
Closed
14 tasks
dhermes reviewed Oct 25, 2016
View reviewed changes

dhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some comments, as discussed in chat, the impl. should resemble the Pub/Sub and Logging implementations, i.e. separation of concerns by having HTTP-only and GAX-only API objects.

Comment thread speech/google/cloud/speech/transcript.py
return cls(transcript['transcript'], transcript['confidence'])

@classmethod
def from_pb(cls, transcript):

This comment was marked as spam.

Sign in to view

Comment thread speech/google/cloud/speech/transcript.py Outdated
def from_pb(cls, transcript):
"""Factory: construct ``Transcript`` from protobuf response.

:type transcript: :class:`SpeechRecognitionAlternative`

This comment was marked as spam.

Sign in to view

Comment thread speech/google/cloud/speech/transcript.py Outdated
:param transcript: Instance of ``SpeechRecognitionAlternative``
from protobuf.

:rtype: :class:`~Transcript`

This comment was marked as spam.

Sign in to view

Comment thread speech/unit_tests/test_client.py
max_alternatives=2,
profanity_filter=True,
speech_context=self.HINTS)
with _Monkey(MUT, _USE_GAX=False):

This comment was marked as spam.

Sign in to view

Comment thread speech/unit_tests/test_client.py
sample = Sample(source_uri=self.AUDIO_SOURCE_URI, encoding=encoding,
sample_rate=self.SAMPLE_RATE)
response = client.sync_recognize(sample)
with _Monkey(MUT, _USE_GAX=False):

This comment was marked as spam.

Sign in to view

Comment thread speech/unit_tests/test_client.py Outdated
encoding=speech.Encoding.FLAC,
sample_rate=self.SAMPLE_RATE)
client.sync_recognize(sample)
with self.assertRaises(IndexError):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread speech/unit_tests/test_client.py
sample_rate=self.SAMPLE_RATE)
client.sync_recognize(sample)
with self.assertRaises(IndexError):
with _Monkey(MUT, _USE_GAX=False):

This comment was marked as spam.

Sign in to view

Comment thread speech/unit_tests/test_client.py Outdated


class _RecognitionConfig(object):
def __init__(self, *args, **kwargs):

This comment was marked as spam.

Sign in to view

dhermes reviewed Oct 26, 2016
View reviewed changes

dhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Big 👍 on the refactor

Comment thread speech/google/cloud/speech/_gax.py
@@ -0,0 +1,76 @@

This comment was marked as spam.

Sign in to view

Comment thread speech/google/cloud/speech/client.py Outdated
_USE_GAX = _HAVE_GAX and not _DISABLE_GAX


class Client(JSONClient):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread speech/google/cloud/speech/client.py
try:
from google.cloud.speech._gax import GAPICSpeechAPI
except ImportError: # pragma: NO COVER
_HAVE_GAX = False

This comment was marked as spam.

Sign in to view

Comment thread speech/google/cloud/speech/client.py
"""Helper for speech-related API calls."""
if self._speech_api is None:
if self._use_gax:
self._speech_api = GAPICSpeechAPI()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread speech/google/cloud/speech/client.py Outdated
profanity_filter, speech_context)

api_response = self.connection.api_request(
class JSONSpeechAPI(object):

This comment was marked as spam.

Sign in to view

Comment thread speech/unit_tests/test_client.py Outdated
self.assertFalse(operation.complete)
self.assertIsNone(operation.metadata)

def test_speech_api_with_gapic(self):

This comment was marked as spam.

Sign in to view

Comment thread speech/unit_tests/test_client.py Outdated
api = client.speech_api
self.assertIsInstance(api, _MockGAPICSpeechAPI)

def test_speech_api_without_gapic(self):

This comment was marked as spam.

Sign in to view

Comment thread speech/unit_tests/test_client.py
api = client.speech_api
self.assertIsInstance(api, _MockJSONSpeechAPI)

def test_speech_api_preset(self):

This comment was marked as spam.

Sign in to view

Comment thread speech/google/cloud/speech/_gax.py Outdated


class GAPICSpeechAPI(object):
"""Object to manage calls through GAPIC wrappers to the Speech API."""

This comment was marked as spam.

Sign in to view

Comment thread speech/google/cloud/speech/_gax.py Outdated
uri=sample.source_uri)
api = self._gapic_api
api_response = api.sync_recognize(config=config, audio=audio)
results = api_response.results.pop()

This comment was marked as spam.

Sign in to view

dhermes reviewed Oct 26, 2016
View reviewed changes
Comment thread speech/setup.py Outdated
REQUIREMENTS = [
'google-cloud-core >= 0.20.0',
'gapic-google-cloud-speech-v1beta1==0.11.1',
'grpc-google-cloud-speech-v1beta1==0.11.1',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread speech/unit_tests/test_client.py
credentials = _Credentials()
client = self._makeOne(credentials=credentials)
client = self._makeOne(credentials=credentials, use_gax=False)
client.connection = _Connection(RETURNED)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

daspecster force-pushed the add-speech-sync-gapic branch from 7e2e8f4 to e24e96a Compare October 26, 2016 03:48

daspecster commented Oct 26, 2016

Copy link
Copy Markdown
Contributor Author

It looks like SpeechApi() does some credential digging.
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/170660357#L201-L212

So I _Monkey'd SpeechApi back.

@dhermes I think I got everything you covered there. LMKWYT.

daspecster commented Oct 26, 2016

Copy link
Copy Markdown
Contributor Author

Yeah I was trying something with testing. I just pushed that back up.

daspecster commented Oct 26, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ok yeah, that causes an error.
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/170666346#L461-L474
I think because of this https://pypi.python.org/pypi/grpc-google-cloud-speech-v1beta1/1.0.0

daspecster force-pushed the add-speech-sync-gapic branch 2 times, most recently from d3d3ced to 9c3a578 Compare October 26, 2016 04:38

daspecster commented Oct 26, 2016

Copy link
Copy Markdown
Contributor Author

Ok that should be resolved now.

    'gapic-google-cloud-speech-v1beta1>=0.11.1,<0.12.0',
    'grpc-google-cloud-speech-v1beta1>=0.11.1,<0.12.0',

dhermes commented Oct 26, 2016

Copy link
Copy Markdown
Contributor

LGTM.

daspecster force-pushed the add-speech-sync-gapic branch from 29cb827 to 9031a0f Compare October 26, 2016 05:07
daspecster merged commit 2e6ac38 into googleapis:master Oct 26, 2016
daspecster deleted the add-speech-sync-gapic branch October 26, 2016 05:25
dhermes mentioned this pull request Nov 14, 2016
Merged
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Merge pull request googleapis#2615 from daspecster/add-speech-sync-gapic
dce4dfe 
Add Speech GAPIC for sync_recognize.
atulep pushed a commit that referenced this pull request Apr 3, 2023
Merge pull request #2615 from daspecster/add-speech-sync-gapic
6fd2058 
Add Speech GAPIC for sync_recognize.
atulep pushed a commit that referenced this pull request Apr 18, 2023
Merge pull request #2615 from daspecster/add-speech-sync-gapic
898f5ad 
Add Speech GAPIC for sync_recognize.
parthea pushed a commit that referenced this pull request Oct 22, 2023
Merge pull request #2615 from daspecster/add-speech-sync-gapic
91a1927 
Add Speech GAPIC for sync_recognize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
bjwatson bjwatson left review comments
dhermes dhermes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

tseaver

Labels

api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL