Converting Pub/Sub topic->list_subscriptions to iterator. - #2618
Merged
dhermes merged 1 commit intoOct 27, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tseaver
approved these changes
Oct 26, 2016
dhermes
force-pushed
the
pubsub-iterators-2
branch
from
61d1d46 to
8742eb1
Compare
October 27, 2016 16:46
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Converting Pub/Sub topic->list_subscriptions to iterator.
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
Converting Pub/Sub topic->list_subscriptions to iterator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Has #2617 as diffbase, though has only one commit.
NOTE: _item_to_subscription is identically defined in _gax and connection, since in either case the API just returns strings.
Also worth noting that the mocks in the unit tests were returning values different from what the actual responses returned.