Converting Pub/Sub client->list_subscriptions to iterator. - #2633
Merged
dhermes merged 5 commits intoOct 29, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Also replacing _subscription_pb_to_mapping with MessageToDict.
Making it more specific to the methods that use it (topic_list_subscriptions) since list_subscriptions will also need to convert an item to a subscription.
Also remove GAX confusion in Pub/Sub between max_results and page_size.
These changes are needed to cover the change to iterators.
daspecster
reviewed
Oct 29, 2016
daspecster
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This LGTM. @tseaver?
Sorry, something went wrong.
Comment thread
pubsub/google/cloud/pubsub/_gax.py
| raise Conflict(topic_path) | ||
| raise | ||
| return _subscription_pb_to_mapping(sub_pb) | ||
| return MessageToDict(sub_pb) |
This comment was marked as spam.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Converting Pub/Sub client->list_subscriptions to iterator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is surprisingly no system test for Client.list_subscriptions(). After seeing how different the implementations of Client.list_subscriptions() and Topic.list_subscriptions() are, I am strongly for adding such a system test.
Sending this out without fixing unit tests to get it in the hands of reviewers. The unit tests may take me a non-trivial time, but I am working on them.