Add speech async JSON/REST system tests. - #2648
Merged
daspecster merged 1 commit intoOct 31, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
14 tasks
dhermes
reviewed
Oct 31, 2016
Comment thread
system_tests/speech.py
Outdated
|
|
||
| def _make_async_request(self, content=None, source_uri=None, | ||
| max_alternatives=None): | ||
| client = speech.Client(use_gax=False) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
system_tests/speech.py
Outdated
| profanity_filter=True, | ||
| speech_context=['Google', 'cloud']) | ||
|
|
||
| return result |
This comment was marked as spam.
Comment thread
system_tests/speech.py
Outdated
| import time | ||
| with open(AUDIO_FILE, 'rb') as file_obj: | ||
| operation = self._make_async_request(content=file_obj.read(), | ||
| max_alternatives=2) |
This comment was marked as spam.
Comment thread
system_tests/speech.py
Outdated
| self._check_best_results(result) | ||
|
|
||
| def test_async_recognize_local_file(self): | ||
| import time |
This comment was marked as spam.
Comment thread
system_tests/speech.py
Outdated
| while retry_count > 0 and not operation.complete: | ||
| retry_count -= 1 | ||
| time.sleep(10) | ||
| operation.poll() |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
system_tests/speech.py
Outdated
| source_uri = 'gs://%s/%s' % (bucket_name, blob_name) | ||
| operation = self._make_async_request(source_uri=source_uri, | ||
| max_alternatives=2) | ||
| retry_count = 100 |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
system_tests/speech.py
Outdated
| retry_count = 100 | ||
| while retry_count > 0 and not operation.complete: | ||
| retry_count -= 1 | ||
| time.sleep(10) |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
system_tests/speech.py
Outdated
| results = operation.results | ||
| self.assertIsInstance(results[0], Transcript) | ||
| self.assertEqual(results[0].transcript, 'hello ' + self.ASSERT_TEXT) | ||
| self.assertGreater(results[0].confidence, 0.90) |
This comment was marked as spam.
dhermes
reviewed
Oct 31, 2016
Comment thread
system_tests/speech.py
Outdated
| """ | ||
|
|
||
| def _operation_complete(result): | ||
| return result |
This comment was marked as spam.
This comment was marked as spam.
dhermes
reviewed
Oct 31, 2016
Comment thread
system_tests/speech.py
| def test_async_recognize_local_file(self): | ||
| import time | ||
| if Config.USE_GAX: | ||
| self.skipTest('async_recognize gRPC not yet implemented.') |
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
LGTM (assuming you are tracking those skipTest usages) |
Sorry, something went wrong.
dhermes
reviewed
Oct 31, 2016
Comment thread
system_tests/speech.py
Outdated
| :rtype: bool | ||
| :returns: Boolean indicating if the operation is complete. | ||
| """ | ||
|
|
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
dhermes
approved these changes
Oct 31, 2016
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM provided you are tracking skipTest
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Ok I'm squashing now. Thanks! |
Sorry, something went wrong.
daspecster
force-pushed
the
add-speech-async-rest-system-tests
branch
from
b79b1ee to
80e4143
Compare
October 31, 2016 17:05
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…est-system-tests Add speech async JSON/REST system tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds JSON/REST system tests for speech's async_recognize() method.