Updating list_metrics() to Iterator pattern. - #2653
Merged
dhermes merged 4 commits intoNov 1, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dhermes
force-pushed
the
logging-iterators-metrics
branch
2 times, most recently
from
fc6e57f to
5b33597
Compare
October 31, 2016 23:31
Copy link
Copy Markdown
Contributor
|
pyilnt failure: logging/google/cloud/logging/_gax.py:500:1: E303 too many blank lines (3) |
Sorry, something went wrong.
dhermes
force-pushed
the
logging-iterators-metrics
branch
from
5b33597 to
ce40029
Compare
November 1, 2016 04:46
Copy link
Copy Markdown
Contributor
Author
|
Ahhhh! Darn rebases. PTAL. Was that your only issue? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I didn't really review it in detail since Travis was red. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
OK well it's good to go now. LMK what you think |
Sorry, something went wrong.
tseaver
reviewed
Nov 1, 2016
Comment thread
logging/unit_tests/test_client.py
| returned = { | ||
| 'metrics': METRICS, | ||
| } | ||
| client.connection = _Connection(returned) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
logging/unit_tests/test_client.py
Outdated
| token = iterator.next_page_token | ||
|
|
||
| # First check the token. | ||
| self.assertIsNone(token) |
This comment was marked as spam.
This comment was marked as spam.
dhermes
force-pushed
the
logging-iterators-metrics
branch
from
ce40029 to
9cf835c
Compare
November 1, 2016 16:24
tseaver
approved these changes
Nov 1, 2016
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…rics Updating list_metrics() to Iterator pattern.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Updating list_metrics() to Iterator pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Has #2651 as diffbase. Unit test changes will be forthcoming.