Renaming connection module as _http in 5 packages. - #2690
Merged
dhermes merged 4 commits intoNov 7, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The packages are BigQuery, Datastore, Logging, Pub/Sub and Storage. The rename is in advance of a larger re-factor. But so long as the connections are not public, the re-factor can happen without user-facing implications.
tseaver
approved these changes
Nov 7, 2016
tseaver
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, however you decide about the datastore.batch.Batch.connection property.
Sorry, something went wrong.
Comment thread
datastore/google/cloud/datastore/batch.py
| :rtype: :class:`google.cloud.datastore._http.Connection` | ||
| :returns: The connection over which the batch will run. | ||
| """ | ||
| return self._client.connection |
This comment was marked as spam.
This comment was marked as spam.
This was referenced Nov 8, 2016
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…ublic Renaming connection module as _http in 5 packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packages are BigQuery, Datastore, Logging, Pub/Sub and Storage.
The rename is in advance of a larger re-factor (#2606). But so long as the connections are not public, the re-factor can happen without user-facing implications.
I'd also like to make all the connection attributes on instances into _connection. @tseaver Is it OK to put that change in this PR?