FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove speech package not yet released warning. by daspecster · Pull Request #2732 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Remove speech package not yet released warning. - #2732

Merged
dhermes merged 1 commit into
googleapis:masterfrom
daspecster:remove-unreleased-speech-warning
Nov 14, 2016
ConversationCommits (1)ChecksFiles changed
Merged

Remove speech package not yet released warning.#2732
dhermes merged 1 commit into
googleapis:masterfrom
daspecster:remove-unreleased-speech-warning

Conversation

daspecster commented Nov 14, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Last checkbox for releasing was to remove the warning about google-cloud-speech not being available on PyPI.

Do not merge until after release to PyPI.

daspecster added the api: speech Issues related to the Speech-to-Text API. label Nov 14, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2016
daspecster mentioned this pull request Nov 14, 2016
Closed
14 tasks

tseaver commented Nov 14, 2016

Copy link
Copy Markdown
Contributor

Seems like we shouldn't merge this PR until we have actually pushed a release to PyPI.

daspecster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 14, 2016

daspecster commented Nov 14, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver, actually probably just before right?

tseaver commented Nov 14, 2016

Copy link
Copy Markdown
Contributor

actually probably just before right?

I was figuring that he sdist/bdist_wheel distributions don't contain the docs, so there is no particular reason to have them tell "proactive truth": the only people who will see the docs changes will be looking at gh-pages or RTD, and so it would be better if the PyPI release had distributions when the docs change materialized. I guess the "stable" docs should show the change, which is a point in your favor.

dhermes merged commit f6f02f6 into googleapis:master Nov 14, 2016

dhermes commented Nov 14, 2016

Copy link
Copy Markdown
Contributor

This discussion luckily culminates in #2733!

daspecster deleted the remove-unreleased-speech-warning branch January 24, 2017 15:16
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Merge pull request googleapis#2732 from daspecster/remove-unreleased-…
3cb6daa 
…speech-warning

Remove speech package not yet released warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

tseaver

Labels

api: speech Issues related to the Speech-to-Text API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL