Allow using a metric type in the Query method select_metrics. - #2735
Closed
supriyagarg wants to merge 2 commits into
Closed
Allow using a metric type in the Query method select_metrics.#2735supriyagarg wants to merge 2 commits into
supriyagarg wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
supriyagarg
force-pushed
the
monitoring_select_metrics
branch
4 times, most recently
from
4d42b87 to
90ff89b
Compare
November 14, 2016 23:29
dhermes
reviewed
Nov 14, 2016
Comment thread
monitoring/google/cloud/monitoring/query.py
Outdated
| new_metric_type = kwargs.get('metric_type') | ||
| if new_metric_type is not None: | ||
| self.metric_type = new_metric_type | ||
| kwargs.pop('metric_type', None) |
This comment was marked as spam.
This comment was marked as spam.
supriyagarg
force-pushed
the
monitoring_select_metrics
branch
2 times, most recently
from
b7335ab to
84122a1
Compare
November 15, 2016 01:00
dhermes
approved these changes
Nov 15, 2016
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM other than one tiny nit
Sorry, something went wrong.
Comment thread
monitoring/google/cloud/monitoring/query.py
Outdated
|
|
||
| As a special case, ``"metric_type"`` is treated as a special | ||
| pseudo-label corresponding to the filter object ``metric.type``. | ||
| For example, ``metric_type=<value>`` generates:: |
This comment was marked as spam.
This comment was marked as spam.
This is useful when a user wants to apply the exact same filters (duration, aggregation, resource labels) for a different metric type.
supriyagarg
force-pushed
the
monitoring_select_metrics
branch
from
84122a1 to
52f304f
Compare
November 22, 2016 00:12
Copy link
Copy Markdown
Contributor
|
Hi @supriyagarg, We are still willing to accept this in principle, but can not make changes to your PR (since you have it configured not to allow this). Therefore, I am going to close this issue as stale for now. If you would like to make the necessary updates, though, we would be happy to consider doing this. |
Sorry, something went wrong.
vchudnov-g
pushed a commit
that referenced
this pull request
Sep 20, 2023
…udPlatform/python-docs-samples#2735) * dialogflow: split up entity and entity type tests * delete old file * run black on new files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful when a user wants to apply the exact same filters (duration, aggregation, resource labels) for a different metric type.