Fix vision error when no results returned. - #2750
Merged
daspecster merged 3 commits intoNov 17, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dhermes
reviewed
Nov 17, 2016
Comment thread
vision/google/cloud/vision/image.py
Outdated
|
|
||
| detected_objects = [] | ||
| feature_key = _REVERSE_TYPES[feature_type] | ||
| annotations = results.get(feature_key, []) |
This comment was marked as spam.
dhermes
approved these changes
Nov 17, 2016
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Comment thread
vision/unit_tests/test_client.py
| self.assertEqual(5, image_request['features'][0]['maxResults']) | ||
|
|
||
| def test_face_detection_from_content_no_results(self): | ||
| RETURNED = { |
This comment was marked as spam.
Comment thread
vision/unit_tests/test_client.py
| faces = image.detect_faces(limit=5) | ||
| self.assertEqual(faces, []) | ||
| self.assertEqual(len(faces), 0) | ||
| image_request = client._connection._requested[0]['data']['requests'][0] |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
@dhermes, I'll merge this and follow up with some test improvements. |
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…-results Fix vision error when no results returned.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
Fix vision error when no results returned.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…#2750)](GoogleCloudPlatform/python-docs-samples#2750) * automl: video beta - move beta samples out of branch and into master * lint * update error message on batch predict Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2749.