Fix double encoding of messages when commit() fails. - #2773
Merged
daspecster merged 1 commit intoNov 29, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dhermes
reviewed
Nov 28, 2016
Comment thread
pubsub/google/cloud/pubsub/_http.py
| :returns: list of opaque IDs for published messages. | ||
| """ | ||
| _transform_messages_base64(messages, _base64_unicode) | ||
| messages_to_send = copy.deepcopy(messages) |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…ommits-if-failed-2771 Fix double encoding of messages when commit() fails.
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
…failed-2771 Fix double encoding of messages when commit() fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2771
This copies the messages variable instead of transforming it in place so that if a commit() fails, the messages aren't double encoded.