Add system test for Vision Logo detection. - #2788
Merged
daspecster merged 1 commit intoDec 2, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
10 tasks
dhermes
reviewed
Dec 1, 2016
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Mostly LG but a few changes are "needed"
Sorry, something went wrong.
Comment thread
system_tests/run_system_test.py
| TEST_MODULES = { | ||
| 'datastore': datastore, | ||
| 'speech': speech, | ||
| 'vision': vision, |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
system_tests/vision.py
Outdated
| CLIENT = None | ||
| TEST_BUCKET = None | ||
|
|
||
| LOGO_FILE = os.path.join(os.path.dirname(__file__), 'data', 'logo.png') |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
system_tests/vision.py
Outdated
| bucket_retry(Config.TEST_BUCKET.delete)(force=True) | ||
|
|
||
|
|
||
| class TestSpeechClient(unittest.TestCase): |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
system_tests/vision.py
| value.delete() | ||
|
|
||
| def _assert_logo(self, logo): | ||
| self.assertEqual(logo.description, 'Google') |
This comment was marked as spam.
daspecster
force-pushed
the
vision-add-system-tests
branch
from
bd0270b to
c6019d8
Compare
December 2, 2016 18:38
Copy link
Copy Markdown
Contributor
Author
|
I added the filename test as well. system-tests runtests: commands[1] | python /Users/daspecster/Documents/google/google-cloud-python/system_tests/attempt_system_tests.py vision
test_detect_logos_content (vision.TestVisionClient) ... ok
test_detect_logos_filename (vision.TestVisionClient) ... ok
test_detect_logos_gcs (vision.TestVisionClient) ... ok
----------------------------------------------------------------------
Ran 3 tests in 5.540s
OK
____________________________________________________ summary _____________________________________________________
system-tests: commands succeeded
congratulations :) |
Sorry, something went wrong.
dhermes
approved these changes
Dec 2, 2016
daspecster
force-pushed
the
vision-add-system-tests
branch
from
c6019d8 to
e6ea013
Compare
December 2, 2016 20:14
Copy link
Copy Markdown
Contributor
Author
|
Squashed! And cancelled travis #SaveCycles. |
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…tests Add system test for Vision Logo detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards: #2753 and #2526.
I will add the filename test after #2778 is merged.
To get this kicked off though, here are some system tests for detect_logo().