FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Upgrading GAPIC deps to 0.14 series. by dhermes · Pull Request #2795 · googleapis/google-cloud-python · GitHub

Upgrading GAPIC deps to 0.14 series. - #2795

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:update-gapic-0.14
Dec 3, 2016
Merged

Upgrading GAPIC deps to 0.14 series.#2795
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:update-gapic-0.14

Conversation

dhermes commented Dec 2, 2016

Copy link
Copy Markdown
Contributor

In the process, ditching hard deps on protobufs, grpcio, and google-gax in those packages. Also had
to upgrade calls to list_log_entries() based on: https://github.com/googleapis/api-client-staging/pull/118/files/2bcd2875a578ae525d2aabb862cf9c131b4665f5#r90422054

/cc @geigerj @bjwatson

@waprin I could not for the life of me figure out how to use resource_names instead of the deprecated project_ids. Can you explain? (Trying foo --> project/foo did not work)

In the process, ditching **hard** deps on protobufs,
grpcio, and google-gax in those packages. Also had
to upgrade calls to list_log_entries() based on

https://github.com/googleapis/api-client-staging/pull/118/files/2bcd2875a578ae525d2aabb862cf9c131b4665f5#r90422054
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2016

tseaver commented Dec 2, 2016

Copy link
Copy Markdown
Contributor

@dhermes Should we work out what the story is supposed to be for resource_names before merging?

dhermes commented Dec 2, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver The system tests are still passing, so I don't think it's necessary to block on that, though we should get it straightened out. (Was there a version bump for this API I wasn't aware of that deprecated the field?)

waprin commented Dec 2, 2016

Copy link
Copy Markdown
Contributor

@dhermes did you try foo -> projects/foo ? (note the plural projects). Apologies if you just had a typo in your original message, but I do hope that was the problem since it's an easy fix :)

dhermes commented Dec 2, 2016

Copy link
Copy Markdown
Contributor Author

This is what I did before (I know because my chat log with @geigerj)

resource_names = ['project/' + project for project in projects]

@waprin Should we allow callers to send other resource types? I checked and only project IDs come through in the system tests.

geigerj commented Dec 2, 2016

Copy link
Copy Markdown
Contributor

@dhermes project/ -> projects/?

dhermes commented Dec 2, 2016

Copy link
Copy Markdown
Contributor Author

@geigerj Right that's what @waprin just said (and I confirmed I was holding the gun wrong before)

waprin commented Dec 2, 2016

Copy link
Copy Markdown
Contributor

Docs look like there are some "orgazinations/" thing but I'm not familiar with it tbh, will have to ask around.

dhermes commented Dec 2, 2016

Copy link
Copy Markdown
Contributor Author

@tseaver Let's merge this and continue this discussion elsewhere (like a PR which converts projects to resource_names)

tseaver commented Dec 3, 2016

Copy link
Copy Markdown
Contributor

LGTM

dhermes merged commit 7c73b58 into googleapis:master Dec 3, 2016
dhermes deleted the update-gapic-0.14 branch December 3, 2016 00:03
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
atulep pushed a commit that referenced this pull request Apr 3, 2023
Upgrading GAPIC deps to 0.14 series.
atulep pushed a commit that referenced this pull request Apr 18, 2023
Upgrading GAPIC deps to 0.14 series.
parthea pushed a commit that referenced this pull request Oct 22, 2023
Upgrading GAPIC deps to 0.14 series.
parthea pushed a commit that referenced this pull request Nov 24, 2025
Upgrading GAPIC deps to 0.14 series.
parthea pushed a commit that referenced this pull request Mar 2, 2026
Upgrading GAPIC deps to 0.14 series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. grpc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL