| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
In the process, adding a Config.TO_DELETE runtime list so that test cleanup can handle any loose objects created.
|
I like it! |
Sorry, something went wrong.
|
Blerg! Python 2 and 3 strike again: Failed example:
client.get(key)
Expected:
<Entity(u'EntityKind', 1234L) {u'property': 'value'}>
Got:
<Entity('EntityKind', 1234) {'property': 'value'}>
Proposed short-term "fix": Only run snippet tests in Python 2? @jonparrott and @tseaver any better ideas? |
Sorry, something went wrong.
|
@dhermes I hate any testing dependency on repr, period (and tracebacks even worse). |
Sorry, something went wrong.
|
@tseaver Yes I'm aware of your strong opinion. Any construction constructive suggestion? |
Sorry, something went wrong.
|
@dhermes Either change the example not to use the repr, or change the repr not to use the "dict literal" repr of the keys / values. |
Sorry, something went wrong.
Converting remaining datastore snippets to doctests
Converting remaining datastore snippets to doctests
| Back | FazBrowse Home | New Git URL |
It's worth noting that I delegated clean-up to system_tests/datastore.py::tearDownModule. This is because (in my experimenting) I discovered that the sphinx.ext.doctest directive testcleanup doesn't run when the thing being tested fails. (FWIW, I think it'd be fairly easy for one of us to send a PR to the Sphinx project and fix that behavior, but that was outside the scope of this PR.)
To make dev a little faster I did the following:
and every time I made a change I just re-installed into the env
Might be worth turning this into a script someday? But I don't want to design it before we know how we'll use it. Just putting it here for posterity.
There is a code-block snippet in datastore._http but that module is non-public so I left it alone.
This package could use some more snippets, but for now at least they are all covered.