Separate HTTP client. - #2845
Merged
daspecster merged 1 commit intoDec 15, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
dhermes
reviewed
Dec 8, 2016
Comment thread
vision/google/cloud/vision/_rest.py
Outdated
| @@ -0,0 +1,91 @@ | |||
| # Copyright 2016 Google Inc. | |||
This comment was marked as spam.
Comment thread
vision/google/cloud/vision/_rest.py
Outdated
| from google.cloud.vision.feature import Feature | ||
|
|
||
|
|
||
| class _RESTVisionAPI(object): |
This comment was marked as spam.
Comment thread
vision/google/cloud/vision/_rest.py
Outdated
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """REST Client for interacting with the Google Cloud Vision API.""" |
This comment was marked as spam.
Comment thread
vision/google/cloud/vision/_rest.py
Outdated
| if isinstance(features, list): | ||
| self._features.extend(features) | ||
| elif isinstance(features, Feature): | ||
| self._features.append(features) |
This comment was marked as spam.
Comment thread
vision/google/cloud/vision/_rest.py
Outdated
| return response['responses'][0] | ||
|
|
||
|
|
||
| class VisionRequest(object): |
This comment was marked as spam.
Comment thread
vision/google/cloud/vision/_rest.py
Outdated
| response = self._connection.api_request( | ||
| method='POST', path='/images:annotate', data=data) | ||
|
|
||
| return response['responses'][0] |
This comment was marked as spam.
Comment thread
vision/google/cloud/vision/client.py
Outdated
| source_uri=source_uri) | ||
|
|
||
| @property | ||
| def vision_api(self): |
This comment was marked as spam.
dhermes
reviewed
Dec 9, 2016
Comment thread
vision/google/cloud/vision/_http.py
Outdated
| features = [features] | ||
|
|
||
| feature_check = (isinstance(feature, Feature) for feature in features) | ||
| if not isinstance(features, list) or not any(feature_check): |
This comment was marked as spam.
Comment thread
vision/google/cloud/vision/_http.py
Outdated
|
|
||
| return { | ||
| 'image': image.as_dict(), | ||
| 'features': [feature.as_dict() for feature in features] |
This comment was marked as spam.
Comment thread
vision/unit_tests/test__http.py
Outdated
| from google.cloud.vision.image import Image | ||
|
|
||
| credentials = _make_credentials() | ||
| client = Client(project=PROJECT, credentials=credentials) |
This comment was marked as spam.
Comment thread
vision/unit_tests/test_client.py
Outdated
|
|
||
| class MockVisionAPI(object): | ||
| def annotate(self): | ||
| return True |
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
|
Yes, though it seems the rebase of #2870 into this would be easier than the other way around. WDYT? |
Sorry, something went wrong.
daspecster
force-pushed
the
vision-separate-rest-client
branch
from
23fd960 to
fb6f7f8
Compare
December 15, 2016 20:02
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
daspecster
force-pushed
the
vision-separate-rest-client
branch
from
fb6f7f8 to
74e537b
Compare
December 15, 2016 20:33
Copy link
Copy Markdown
Contributor
Author
|
Rebased and squashed. Will merge once build passes. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
SGTM |
Sorry, something went wrong.
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…st-client Separate HTTP client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #2753 for adding GAPIC support.
Separates out the REST client in preparation to add the GAPIC client alongside.