FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for pubsub scope error. by daspecster · Pull Request #2909 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Fix for pubsub scope error. - #2909

Merged
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:fix-pubsub-grpc-credentials
Jan 3, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Fix for pubsub scope error.#2909
daspecster merged 1 commit into
googleapis:masterfrom
daspecster:fix-pubsub-grpc-credentials

Conversation

daspecster commented Dec 29, 2016

Copy link
Copy Markdown
Contributor

Closes #2908

I'm not sure this is the right way to go about fixing this. But it works!

daspecster added the api: pubsub Issues related to the Pub/Sub API. label Dec 29, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 29, 2016

dhermes commented Dec 29, 2016

Copy link
Copy Markdown
Contributor

Indeed. DERP!

I was assuming that (also here)

client._credentials is client._connection._credentials

in #2874 (and maybe #2875). But that isn't true: the Connection constructor calls google.auth.credentials.with_scopes_if_required.

dhermes commented Dec 29, 2016

Copy link
Copy Markdown
Contributor

@daspecster I'm not really sure what to do here. Pub/Sub and Logging are "half-way" to just removing Connection altogether (or having a very different / stripped down version of the Connection). So this change needed to be made as part of that effort, the effort just got halted by Santa.

daspecster commented Dec 29, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

🎅 💥

Ok, I can try and continue with the "extraction". But if you want too, I'll close this and keep rolling with other things.

Edit: I just realized that my emoji look like I'm blowing up santa...I was going for Santa blowing up pubsub and logging...ha

dhermes commented Jan 3, 2017

Copy link
Copy Markdown
Contributor

@daspecster I think the right fix (for now) is to just use client._connection._credentials (here and here).

daspecster force-pushed the fix-pubsub-grpc-credentials branch from 8312d29 to 7df7bc0 Compare January 3, 2017 16:57

daspecster commented Jan 3, 2017

Copy link
Copy Markdown
Contributor Author

Update pushed! I ran the system tests and they passed so that should do the trick!

dhermes commented Jan 3, 2017

Copy link
Copy Markdown
Contributor

👍 LGTM to merge (Travis is green already)

daspecster merged commit 61d63e5 into googleapis:master Jan 3, 2017
daspecster deleted the fix-pubsub-grpc-credentials branch January 3, 2017 17:14
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Jan 12, 2017
Fixing credentials without scopes issue in logging.
8675e88 
See:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/191433056#L2195

This is a band-aid for now. I caused it in googleapis#2875 and will roll-back this
roll-back at a later time.

@daspecter fixed a similar breakage in googleapis#2909.
dhermes mentioned this pull request Jan 12, 2017
Merged
dhermes mentioned this pull request Feb 24, 2017
Merged
19 tasks
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Merge pull request googleapis#2909 from daspecster/fix-pubsub-grpc-cr…
cc10ac3 
…edentials

Fix for pubsub scope error.
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Fixing credentials without scopes issue in logging.
b0dfd7b 
See:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/191433056#L2195

This is a band-aid for now. I caused it in googleapis#2875 and will roll-back this
roll-back at a later time.

@daspecter fixed a similar breakage in googleapis#2909.
parthea pushed a commit that referenced this pull request Nov 24, 2025
Fixing credentials without scopes issue in logging.
5b0945f 
See:
https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/191433056#L2195

This is a band-aid for now. I caused it in #2875 and will roll-back this
roll-back at a later time.

@daspecter fixed a similar breakage in #2909.
parthea pushed a commit that referenced this pull request Mar 2, 2026
Merge pull request #2909 from daspecster/fix-pubsub-grpc-credentials
58c8298 
Fix for pubsub scope error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

tseaver

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gRPC pubsub missing scope error

4 participants

Back | FazBrowse Home | New Git URL