FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Making Connection()-s act as proxies for data stored in Client()-s by dhermes · Pull Request #2970 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Making Connection()-s act as proxies for data stored in Client()-s - #2970

Merged
dhermes merged 16 commits into
googleapis:masterfrom
dhermes:cnxn-client-hygiene
Jan 30, 2017
ConversationCommits (16)ChecksFiles changed
Merged

Making Connection()-s act as proxies for data stored in Client()-s#2970
dhermes merged 16 commits into
googleapis:masterfrom
dhermes:cnxn-client-hygiene

Conversation

dhermes commented Jan 27, 2017

Copy link
Copy Markdown
Contributor

This is part of a re-factoring effort to remove / reduce the role of Connection classes (since they are outdated): #2606

I ran the system tests and speech is failing but I think it's unrelated to this? Also, the umbrella coverage is failing, so I sent #2969 to fix (also unrelated to this PR).

dhermes added 15 commits January 26, 2017 15:17
Moving _http and _credentials default values from base connection to …
1efdb00 
…client.

Still leaving proxy properties on Connection to point to the http
and credentials objects owned by the client.
Changing datastore Connection to only accept client.
a32a022
Changing vision Connection to only accept client.
a65f754
Changing BigQuery Connection to only accept client.
047d13e
Changing DNS Connection to only accept client.
d961233
Changing translate Connection to only accept client.
683ce71
Changing speech Connection to only accept client.
f0adea3
Changing runtimeconfig Connection to only accept client.
c91fa4a
Changing resource manager Connection to only accept client.
cb6e0be
Changing language Connection to only accept client.
725b4f0
Changing monitoring Connection to only accept client.
ad9417f
Changing Pub / Sub Connection to only accept client.
69d998d
Changing logging Connection to only accept client.
f651cce
Changing storage Connection to only accept client.
111c7ef
Fix-up docstrings after Connection() signature change.
45d81a0
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2017
dhermes added api: core hygiene and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 27, 2017
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 27, 2017

daspecster commented Jan 27, 2017

Copy link
Copy Markdown
Contributor

@dhermes #2965 should get the speech system tests working again.

dhermes commented Jan 30, 2017

Copy link
Copy Markdown
Contributor Author

@lukesneeringer @tseaver PTAL. This is (most likely) blocking a google-cloud-core release, which is blocked all other pending releases.

lukesneeringer approved these changes Jan 30, 2017
View reviewed changes

lukesneeringer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks fine to me (while acknowledging my limitations in reading a huge PR).

tseaver commented Jan 30, 2017

Copy link
Copy Markdown
Contributor

LGTM.

@lukesneeringer Are you from Texas? That avatar image looks like the "Come and Take It!" flag.

dhermes merged commit 3584917 into googleapis:master Jan 30, 2017
dhermes deleted the cnxn-client-hygiene branch January 30, 2017 18:26

lukesneeringer commented Jan 30, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Yeah; I just moved to California in December after living in Texas for most of the last 3.5 decades. :-) (I also had a six month stint in Virginia.)

tseaver commented Jan 30, 2017

Copy link
Copy Markdown
Contributor

We've been in Virginia for the last 17 years, but I'm still a Texan (I taught Texas history to seventh graders long ago in a galaxy far away).

dhermes mentioned this pull request Jan 30, 2017
Merged
dhermes mentioned this pull request Feb 24, 2017
Merged
19 tasks
richkadel pushed a commit to richkadel/google-cloud-python that referenced this pull request May 6, 2017
Merge pull request googleapis#2970 from dhermes/cnxn-client-hygiene
e0457d4 
Making Connection()-s act as proxies for data stored in Client()-s
parthea pushed a commit that referenced this pull request Oct 21, 2023
Merge pull request #2970 from dhermes/cnxn-client-hygiene
305ca1b 
Making Connection()-s act as proxies for data stored in Client()-s
parthea pushed a commit that referenced this pull request Mar 2, 2026
Merge pull request #2970 from dhermes/cnxn-client-hygiene
7f6541a 
Making Connection()-s act as proxies for data stored in Client()-s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
lukesneeringer lukesneeringer approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

lukesneeringer

tseaver

Labels

api: core cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL