Are the whitespace changes actually required by the tool, or did you just add them because they seemed needed? I know of no justification in PEP8 etc. for them.

Jinx, bigly

@tseaver I'm wondering if it's a bug in pycodestyle. I moved them around a little bit to try and see what it was looking for and that was the way it had to be to pass. We could probably disable that error.

@daspecster Please provide the errors so we can try to help

There were only two types of errors. One was the bare except and this was the other one.

core/unit_tests/test__helpers.py:147:9: E306 expected 1 blank line before a nested definition, found 0
core/unit_tests/test_credentials.py:34:9: E306 expected 1 blank line before a nested definition, found 0
datastore/unit_tests/test_client.py:159:9: E306 expected 1 blank line before a nested definition, found 0
datastore/unit_tests/test_client.py:518:9: E306 expected 1 blank line before a nested definition, found 0

I vote to suppress that error with prejudice.

I'd agree, we should suppress, but not before filing an issue with the pycodestyle folks

SGTM, I'll update and I can file the issue on pycodestyle as well.

There's a bare except in transaction.py that I'm not sure what the possible exception types could be. I think it could be a few things. If there is a known exception type for this then I can stop ignoring E306.

The except in transaction.py is meant to be bare (it's somewhat of a special case). You can locally disable pycodestyle checks via noqa (e.g.)

The except in transaction.py is meant to be bare (it's somewhat of a special case). You can locally disable pycodestyle checks via noqa (e.g.)

Or except Exception, if it passes the linter.

@lukesneeringer I am allergic to except Exception and that misses nasty exception types that only inherit from BaseException and pylint will complain about Exception being too broad

Fair on all counts. :-)