Rename and move _JSONSpeechAPI to HTTPSpeechAPI. - #2979
Merged
daspecster merged 2 commits intoFeb 6, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lukesneeringer
approved these changes
Feb 1, 2017
lukesneeringer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This seems fine, but @dhermes please give it a once-over also.
Sorry, something went wrong.
dhermes
approved these changes
Feb 1, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Also LGTM
Sorry, something went wrong.
Comment thread
speech/google/cloud/speech/_http.py
| @@ -0,0 +1,211 @@ | |||
| # Copyright 2017 Google Inc. | |||
This comment was marked as spam.
This comment was marked as spam.
Comment thread
speech/google/cloud/speech/_http.py
Outdated
| return [Alternative.from_api_repr(alternative) | ||
| for alternative in result['alternatives']] | ||
| else: | ||
| raise ValueError('More than one result or none returned from API.') |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
speech/google/cloud/speech/_http.py
| """ | ||
| if sample.content is not None: | ||
| audio = {'content': | ||
| _bytes_to_unicode(b64encode(_to_bytes(sample.content)))} |
This comment was marked as spam.
This comment was marked as spam.
daspecster
force-pushed
the
move-speech-http
branch
from
e8857e8 to
2eee25a
Compare
February 6, 2017 16:57
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
* Rename and move _JSONSpeechAPI to HTTPSpeechAPI.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
* Rename and move _JSONSpeechAPI to HTTPSpeechAPI.
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
* Rename and move _JSONSpeechAPI to HTTPSpeechAPI.
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
* Rename and move _JSONSpeechAPI to HTTPSpeechAPI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves _JSONSpeechAPI out of client.py and into _http.py.
Also renames _JSONSpeechAPI -> HTTPSpeechAPI.
#2965 needs to be merged before this.