Moving datastore GAX/gRPC helpers out of _http and into dedicated module. - #3036
Merged
dhermes merged 1 commit intoFeb 22, 2017
Merged
Moving datastore GAX/gRPC helpers out of _http and into dedicated module.#3036dhermes merged 1 commit into
dhermes merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
daspecster
reviewed
Feb 17, 2017
Comment thread
datastore/google/cloud/datastore/_gax.py
Outdated
| @@ -0,0 +1,197 @@ | |||
| # Copyright 2014 Google Inc. | |||
This comment was marked as spam.
This comment was marked as spam.
Comment thread
datastore/google/cloud/datastore/_gax.py
Outdated
|
|
||
| @contextlib.contextmanager | ||
| def _grpc_catch_rendezvous(): | ||
| """Re-map gRPC exceptions that happen in context. |
This comment was marked as spam.
This comment was marked as spam.
dhermes
force-pushed
the
give-datastore-gax
branch
from
ebeb2e7 to
0109bbd
Compare
February 17, 2017 16:35
Copy link
Copy Markdown
Contributor
Author
|
@daspecster I folded those changes into the original commit (since they were super tiny) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
SGTM! Thanks! I know they were nitpicky. The rest LGTM but I feel like someone else should take a crack at it. |
Sorry, something went wrong.
tseaver
reviewed
Feb 17, 2017
Comment thread
datastore/google/cloud/datastore/_http.py
| try: | ||
| from grpc import StatusCode | ||
| from google.cloud.grpc.datastore.v1 import datastore_pb2_grpc | ||
| from google.cloud.datastore._gax import _DatastoreAPIOverGRPC |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
datastore/google/cloud/datastore/_http.py
| from grpc import StatusCode | ||
| from google.cloud.grpc.datastore.v1 import datastore_pb2_grpc | ||
| from google.cloud.datastore._gax import _DatastoreAPIOverGRPC | ||
| _HAVE_GRPC = True |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Comment thread
datastore/google/cloud/datastore/_gax.py
| yield | ||
| except exceptions.GrpcRendezvous as exc: | ||
| error_code = exc.code() | ||
| error_class = _GRPC_ERROR_MAPPING.get(error_code) |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
datastore/google/cloud/datastore/_http.py
| from grpc import StatusCode | ||
| from google.cloud.grpc.datastore.v1 import datastore_pb2_grpc | ||
| from google.cloud.datastore._gax import _DatastoreAPIOverGRPC | ||
| _HAVE_GRPC = True |
This comment was marked as spam.
lukesneeringer
approved these changes
Feb 21, 2017
19 tasks
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Moving datastore GAX/gRPC helpers out of _http and into dedicated module.
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Moving datastore GAX/gRPC helpers out of _http and into dedicated module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 more reviewersAssignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This leaves _http.py closer to what it should look like, but not all the way there (it is doing some of the transport choosing that should be done in client.py)