Add basic helpers needed for GAPIC client in datastore. - #3105
Merged
dhermes merged 1 commit intoMar 6, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Includes - ``use_gax`` argument in Client constructor - ``make_datastore_api`` helper to make a gRPC channel with the correct credentials - A basic ``HTTPDatastoreAPI`` class to act as the equivalent to the GAPIC ``DatastoreClient`` - A lazy property on ``Client`` that will hold the API object.
dhermes
commented
Mar 6, 2017
Comment thread
datastore/google/cloud/datastore/client.py
| return _determine_default_project(project) | ||
|
|
||
| @property | ||
| def _datastore_api(self): |
This comment was marked as spam.
This comment was marked as spam.
daspecster
reviewed
Mar 6, 2017
Comment thread
datastore/google/cloud/datastore/_http.py
| return self._datastore_api.allocate_ids(project, request) | ||
|
|
||
|
|
||
| class HTTPDatastoreAPI(object): |
This comment was marked as spam.
This comment was marked as spam.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 6, 2017
This is to prepare for a removal of the Connection class (relates to googleapis#2746 and googleapis#3105).
lukesneeringer
approved these changes
Mar 6, 2017
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
This is to prepare for a removal of the Connection class (relates to googleapis#2746 and googleapis#3105).
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
Add basic helpers needed for GAPIC client in datastore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewersAssignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes
the correct credentials
to the GAPIC DatastoreClient
object.
Towards #2746.