Fix #161: Make 'Bucket.delete_keys' take an 'on_error' callback by tseaver · Pull Request #312 · googleapis/google-cloud-python · GitHub

Result is a list of (key, success) tuples, one per requested key.

Fixes #161.

Addresses #160 (users who want to delete without raising can use
'Bucket.delete_keys([key])' instead of 'Bucket.delete_key(key)').

Coverage remained the same when pulling 16778cd on tseaver:161-bucket-delete_keys-useful_result into ce7f890 on GoogleCloudPlatform:master.

I'm still not sure how much we should be worrying about folks who pass thousands of keys to delete_keys. If you have reason to think that will be a common case, then something like a callback solution would be the better API design (the default callable would just re-raise the NotFoundError).

Yeah I'm cool with the callback approach, just wanted to raise some questions that might be worth considering.

Coverage remained the same when pulling ab0c141 on tseaver:161-bucket-delete_keys-useful_result into 03d17ba on GoogleCloudPlatform:master.

Result is a list of (key, success) tuples, one per requested key. Fixes #161. Addresses #160 (users who want to delete without raising can use 'Bucket.delete_keys([key])' instead of 'Bucket.delete_key(key)').

If passed, the callback will be called once for each key not found, with the offending key.

Changes Unknown when pulling a0aa94b on tseaver:161-bucket-delete_keys-useful_result into * on GoogleCloudPlatform:master*.

Changes Unknown when pulling f14470f on tseaver:161-bucket-delete_keys-useful_result into * on GoogleCloudPlatform:master*.

LGTM

…sult Fix #161: Make 'Bucket.delete_keys' take an 'on_error' callback

Source-Link: googleapis/synthtool@1b71c10 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@82f5cb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…pprove] (#312) Source-Link: https://togithub.com/googleapis/synthtool/commit/e3a1277ac35fc88c09db1930533e24292b132ced Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2

Source-Link: https://togithub.com/googleapis/synthtool/commit/92006bb3cdc84677aa93c7f5235424ec2b157146 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@06e8279 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:b3500c053313dc34e07b1632ba9e4e589f4f77036a7cf39e1fe8906811ae0fce

* chore: use gapic-generator-python 0.65.2 PiperOrigin-RevId: 444333013 Source-Link: googleapis/googleapis@f91b6cf Source-Link: googleapis/googleapis-gen@16eb360 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZlYjM2MDk1YzI5NGU3MTJjNzRhMWJmMjM1NTA4MTdiNDIxNzRlNSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* chore(python): add nox session to sort python imports Source-Link: googleapis/synthtool@1b71c10 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert change to region tag Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* feat: Update Compute Engine API to revision 20220720 (#723) Source-Link: googleapis/googleapis@60a0fa7 Source-Link: googleapis/googleapis-gen@ba1df1b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmExZGYxYmU5M2Y1YTFhYTVjNjQ3ZmMyZjE5NWQ0MWIwMDc1YWE5MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add replacements in owlbot.py to fix docs build Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* connect Python Translate client library to nebulous serverless example * added Samples section to README * fix path * update README * fix README link * move sample info to README * fix RST formatting * chore: update RST for Sphinx lint * chore: update README for RST style * updated serverless sample README Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@1b9ad76 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9db98b055a7f8bd82351238ccaacfd3cda58cdf73012ab58b8da146368330021

* build(python): release script update Source-Link: googleapis/synthtool@71a7297 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e8dcfd7cbfd8beac3a3ff8d3f3185287ea0625d859168cc80faccfc9a7a00455 * See googleapis/synthtool#2008 --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

- [ ] Regenerate this pull request now. fix: add 'dict' annotation type to 'request' Committer: @busunkim96 PiperOrigin-RevId: 398509016 Source-Link: googleapis/googleapis@b224dfa Source-Link: googleapis/googleapis-gen@63a1db7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjNhMWRiN2EzOGQ3NGI5NjM5NTkyZjUyMWVkMWRhYWY3Mjk5YWQ5YSJ9

* ci: refactor coverage check * update required checks

#312) * chore(python): Update the python version in docs presubmit to use 3.10 Source-Link: googleapis/synthtool@de3def6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:a1c5112b81d645f5bbc4d4bbc99d7dcb5089a52216c0e3fb1203a0eeabadd7d5 * fix lint presubmit * fix lint build * fix lint build * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * exclude .github/workflows/lint.yml * fix lint build --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* docs: add samples for IN, NOT_IN, and != operators. * Update samples/snippets_test.py Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com> * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add an index.yaml file with required indexes * Fix linting errors. Remove unused libraries. * Opt into build specific gcloud projects. * Typo in code comment * Add a test fixture to set up a required index. * Remove snippets that require an index. Will add them in another PR. * Fix linting error * Create a snippets subdirectory under samples * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Use build-specific gcloud projects for noxfile. * Restore noxfile.py to owlbot version. Add noxfile_config.py Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…ow (#312) * feat: add ArrowJSONtype to extend pyarrow for JSONDtype * nit * add JSONArrowScalar * fix cover

The previous `if` condition was inefficient and should have been written with an `and` This resulted in a performance gap. cProfile timing of `export_hocr_string()` on the same document Before ``` 143598720 function calls (129111346 primitive calls) in 44.487 seconds ``` After ``` 97883150 function calls (88084552 primitive calls) in 30.235 seconds ``` Fixes #312 🦕

Fixes #312 🦕 Improves upon the hOCR processing improvements made in #313

Fixes #281.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…elations Implemented: * DatabaseIntrospection.get_primary_key_column * DatabaseIntrospection.get_relations However, get_relations tests CANNOT yet be enabled because Cloud Spanner doesn't yet have ON DELETE cascading for FOREIGN KEYS which limits #313, which renders the method useless as it will always return {} instead of being populated with values that are derived from FOREIGN KEYs. Fixes #312 Updates #311

* fix: refactor type hint retrieval * fix: update spacing * test: update goldens * fix: update prefix start/end removal * fix: update docstring for Annotations

🤖 I have created a release *beep* *boop* --- ## [2.0.6](https://togithub.com/googleapis/sphinx-docfx-yaml/compare/v2.0.5...v2.0.6) (2023-10-30) ### Bug Fixes * Refactor type hint retrieval ([#312](https://togithub.com/googleapis/sphinx-docfx-yaml/issues/312)) ([0c91f60](https://togithub.com/googleapis/sphinx-docfx-yaml/commit/0c91f60fb2eab8b184b1228d5f3eb133be7ae201)) * Support docstrings without type added ([#311](https://togithub.com/googleapis/sphinx-docfx-yaml/issues/311)) ([d214d64](https://togithub.com/googleapis/sphinx-docfx-yaml/commit/d214d64c54d06fa715535b14932ac1ad67fa0d09)) * Update annotation name extraction logic and add unit tests ([#320](https://togithub.com/googleapis/sphinx-docfx-yaml/issues/320)) ([220951d](https://togithub.com/googleapis/sphinx-docfx-yaml/commit/220951d341c27d345679f64fb67968320168e428)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

tseaver mentioned this pull request Oct 29, 2014

Consider allowing storage.bucket.Bucket.delete_key to silently fail if user requests it #160

Closed

dhermes reviewed Oct 29, 2014
View reviewed changes

tseaver changed the title Make 'Bucket.delete_keys' return a useful result. Fix #161: Make 'Bucket.delete_keys' return a useful result. Oct 31, 2014

tseaver added 2 commits October 31, 2014 13:18

Make 'Bucket.delete_keys' return a useful result.

9cbae2c

Result is a list of (key, success) tuples, one per requested key. Fixes #161. Addresses #160 (users who want to delete without raising can use 'Bucket.delete_keys([key])' instead of 'Bucket.delete_key(key)').

Make 'Bucket.delete_keys' take an 'on_error' callback.

a0aa94b

If passed, the callback will be called once for each key not found, with the offending key.

tseaver changed the title Fix #161: Make 'Bucket.delete_keys' return a useful result. Fix #161: Make 'Bucket.delete_keys' take an on_error callback Oct 31, 2014

tseaver changed the title Fix #161: Make 'Bucket.delete_keys' take an on_error callback Fix #161: Make 'Bucket.delete_keys' take an 'on_error' callback Oct 31, 2014

dhermes reviewed Oct 31, 2014
View reviewed changes

Comment thread gcloud/storage/bucket.py

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Re-raise NotFound error from 'Bucket.delete_keys' if no callback passed.

f14470f

tseaver added a commit that referenced this pull request Nov 3, 2014

Merge pull request #312 from tseaver/161-bucket-delete_keys-useful_re…

f33e557

…sult Fix #161: Make 'Bucket.delete_keys' take an 'on_error' callback

tseaver merged commit f33e557 into googleapis:master Nov 3, 2014

tseaver deleted the 161-bucket-delete_keys-useful_result branch November 3, 2014 18:18

dhermes added the api: storage Issues related to the Cloud Storage API. label Dec 31, 2015

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: make samples 3.6 check optional (#312 )

d1a234f

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore: make samples 3.6 check optional (#312 )

ce79689

parthea pushed a commit that referenced this pull request Jun 4, 2023

chore(main): release 1.9.0 (#312 )

0d3b912

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v7.2.0 (#312 )

c93074d

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(python): fix formatting issue in noxfile.py.j2 (#312 )

cea745c

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-pubsub to v2.13.6 (#312 )

5083a9d

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-auth-oauthlib to v0.7.1 (#312 )

8456121

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore: make samples 3.6 check optional (#312 )

1cf499a

parthea added a commit that referenced this pull request Nov 22, 2025

chore: add library type to .repo-metadata.json (#312 )

ecfcc7e

parthea pushed a commit that referenced this pull request Nov 24, 2025

Handle empty signature more elegantly (#312 )

13bf65b

parthea added a commit that referenced this pull request Nov 24, 2025

ci: refactor coverage check (#312 )

1a086da

* ci: refactor coverage check * update required checks

parthea pushed a commit that referenced this pull request Nov 24, 2025

feat: Add Arrow types for efficient JSON data representation in pyarr…

c0d526f

…ow (#312) * feat: add ArrowJSONtype to extend pyarrow for JSONDtype * nit * add JSONArrowScalar * fix cover

parthea added a commit that referenced this pull request Nov 24, 2025

chore: remove unused files (#312 )

e0f323b

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: Refactor page.py to improve performance and organization (#316 )

3ede3cb

Fixes #312 🦕 Improves upon the hOCR processing improvements made in #313

parthea pushed a commit that referenced this pull request Nov 24, 2025

chore(deps): update dependency google-cloud-bigquery to v2.18.0 (#312 )

ea1c65d

parthea pushed a commit that referenced this pull request Nov 24, 2025

fix: don't set key on structured property entities (#312 )

799dd77

Fixes #281.

parthea pushed a commit that referenced this pull request Nov 25, 2025

chore(deps): update dependency google-cloud-bigquery to v2.18.0 (#312 )

8d63230

parthea pushed a commit that referenced this pull request Mar 2, 2026

chore(main): release 2.3.1 (#312 )

b975a15

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Mar 9, 2026

fix: refactor type hint retrieval (#312 )

2cde142

* fix: refactor type hint retrieval * fix: update spacing * test: update goldens * fix: update prefix start/end removal * fix: update docstring for Annotations

Fix #161: Make 'Bucket.delete_keys' take an 'on_error' callback by tseaver · Pull Request #312 · googleapis/google-cloud-python · GitHub

Uh oh!

Fix #161: Make 'Bucket.delete_keys' take an 'on_error' callback - #312

Fix #161: Make 'Bucket.delete_keys' take an 'on_error' callback#312tseaver merged 3 commits intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom tseaver:161-bucket-delete_keys-useful_resultCopy head branch name to clipboard

Conversation

tseaver commented Oct 29, 2014

Uh oh!

coveralls commented Oct 29, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

tseaver commented Oct 30, 2014

Uh oh!

dhermes commented Oct 30, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

coveralls commented Oct 31, 2014

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Nov 1, 2014

Uh oh!

dhermes commented Nov 1, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix #161: Make 'Bucket.delete_keys' take an 'on_error' callback#312
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:161-bucket-delete_keys-useful_result