Add system test for insert/fetch of rows w/ nested schema. - #3140
Merged
tseaver merged 2 commits intoMar 21, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@daspecster, @dhermes Any issues? |
Sorry, something went wrong.
dhermes
reviewed
Mar 15, 2017
Comment thread
system_tests/bigquery.py
| self.assertEqual(len(fetched), len(to_insert)) | ||
|
|
||
| for found, expected in zip(sorted(fetched), sorted(to_insert)): | ||
| self.assertEqual(found[0], expected[0]) # Name |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
system_tests/bigquery.py
|
|
||
| for found, expected in zip(sorted(fetched), sorted(to_insert)): | ||
| self.assertEqual(found[0], expected[0]) # Name | ||
| self.assertEqual(found[1], int(expected[1])) # Age |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
system_tests/bigquery.py
|
|
||
| e_icon = base64.standard_b64decode( | ||
| e_spell['Icon'].encode('ascii')) | ||
| self.assertEqual(f_spell['Icon'], e_icon) |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
system_tests/bigquery_test_data.json
| @@ -0,0 +1,66 @@ | |||
| [ | |||
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
@dhermes I think I answered your questions. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@dhermes, @lukesneeringer, @daspecster Any remaining issues? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
None from me. :-) |
Sorry, something went wrong.
lukesneeringer
approved these changes
Mar 21, 2017
richkadel
pushed a commit
to richkadel/google-cloud-python
that referenced
this pull request
May 6, 2017
…-insert-fetch-w-complex-schema Add system test for insert/fetch of rows w/ nested schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses #3118 as a base.
Derived from schema / data from @tswast.
Toward #3029.