@lukesneeringer I tagged this one "do not merge" because you are still iterating rapidly.

@lukesneeringer I tagged this one "do not merge" because you are still iterating rapidly.

Thank you!

This should be almost ready. Because this commit moves literally everything, it triggers all the system tests now, so they need to pass before it is.

Once it is ready, I will rebase into a smaller number of commits so it is reviewable on a per-commit basis. Once approved, we will still squash. The rebase will be for review's sake.

Hey @tseaver -- Do you happen to know off hand what this failure is about? Is it that the test (or backend) is flaky, or is there something else I should be investigating?

No need to do a ton of research; this is mostly a lazy if-you-know-off-the-top-of-your-head thing.

@lukesneeringer I'm not seeing the error detail show up on Circle CI today: just spinning arrows. I do have a pending Spaner flaky-unit-test fix (#3147), which I'm about to merge.

@tseaver This one is actually a system test; here is the failure:

REDACTED FOR EXCESSIVE LENGTH

I now have CircleCI's build passing...sometimes. We have some system tests that are still flaky and we need to weed out. That said, this is probably close to ready, and still an improvement over where we were.

I will rebase tomorrow so that the PR is parse-able and reviewable.

Also, the total serial test run-time is down to 40 minutes. (I think I could implement some CircleCI caching of the virtualenvs to cut that in half.)

@lukesneeringer Why the merge without review?

It has already gone through a non-trivial amount of review, by everyone here. The only "unreviewed" work was the AppVeyor thrashing.

It looks like CONTRIBUTING.rst still talks about running tox. Possibly other documentation does too. Can you fix it to show how to run tests in the new world? I can't figure out how to even install nox, much less run it.

Ah, I see, this is still open in #3205